71099[TASK] Deprecate service getters in ModuleTemplate
Commit message
Review
-
Code review CR +2 Done
- Georg Ringer +2
- Benni Mack +1
-
Verified V +2 Done
- Georg Ringer +2
- Benni Mack +1
- core-ci +1 CI
Issues 1
Files 12
- typo3/sysext/backend/Classes/Template/ModuleTemplate.php+14 −0
- typo3/sysext/backend/Classes/ViewHelpers/ModuleLayout/Button/AbstractButtonViewHelper.php+3 −3
- typo3/sysext/core/Documentation/Changelog/master/Deprecation-95235-PublicGetterOfServicesInModuleTemplate.rstnew+85 −0
- typo3/sysext/extensionmanager/Classes/Controller/DistributionController.php+5 −2
- typo3/sysext/extensionmanager/Classes/Controller/ExtensionComposerStatusController.php+5 −1
- typo3/sysext/extensionmanager/Classes/Controller/ListController.php+7 −3
- typo3/sysext/fluid/Classes/ViewHelpers/Be/ContainerViewHelper.php+3 −1
- typo3/sysext/form/Classes/Controller/FormEditorController.php+10 −6
- typo3/sysext/form/Classes/Controller/FormManagerController.php+5 −2
- typo3/sysext/indexed_search/Classes/Controller/AdministrationController.php+10 −7
- typo3/sysext/install/Configuration/ExtensionScanner/Php/MethodCallMatcher.php+14 −0
- typo3/sysext/linkvalidator/Classes/Report/LinkValidatorReport.php+8 −5
Review log 57
-
Oli Bartsch uploaded patch set 1 09/16/21, 00:35
-
Oli Bartsch uploaded patch set 2 09/16/21, 00:48
-
core-ci voted on patch set 2 V +1 09/16/21, 01:01 Core CI is happy: https://gitlab.typo3.org/typo3/CI/cms/-/pipelines/16770
-
core-ci voted on patch set 1 V -1 09/16/21, 01:07 Core CI is not happy: https://gitlab.typo3.org/typo3/CI/cms/-/pipelines/16769
-
Benni Mack voted on patch set 2 V +1 CR +1 09/16/21, 09:31
-
Georg Ringer voted on patch set 2 V +2 CR +2 09/16/21, 09:37
-
Georg Ringer merged patch set 3 09/16/21, 09:37