Review main Merged

71099[TASK] Deprecate service getters in ModuleTemplate

Oli Bartsch CR +2 V +2 Normal +169 −30 updated 09/16/21, 09:37

Commit message

The ModuleTemplate, mostly used in backend controllers
previously featured the getIconFactory() and getPageRenderer()
methods, which exposed internally used services.

Except for a few places, TYPO3 core did no longer use
this getters, since it only hides the dependency to the
corresponding services. Therefore, the getters are
now deprecated. Controllers, relying on the services
have to inject them explicitly.

Review

  • Code review CR +2 Done
    • Georg Ringer +2
    • Benni Mack +1
  • Verified V +2 Done
    • Georg Ringer +2
    • Benni Mack +1
    • core-ci +1 CI

Issues 1

Files 12

Review log 57

  1. Oli Bartsch uploaded patch set 1 09/16/21, 00:35

  2. Oli Bartsch uploaded patch set 2 09/16/21, 00:48

  3. core-ci voted on patch set 2 V +1 09/16/21, 01:01 Core CI is happy: https://gitlab.typo3.org/typo3/CI/cms/-/pipelines/16770

  4. core-ci voted on patch set 1 V -1 09/16/21, 01:07 Core CI is not happy: https://gitlab.typo3.org/typo3/CI/cms/-/pipelines/16769

  5. Benni Mack voted on patch set 2 V +1 CR +1 09/16/21, 09:31

  6. Georg Ringer voted on patch set 2 V +2 CR +2 09/16/21, 09:37

  7. Georg Ringer merged patch set 3 09/16/21, 09:37