Review main Merged

71101[TASK] Various clean ups in Page Module code

Benni Mack CR +2 V +2 Easy +11 −36 updated 09/16/21, 10:34

Commit message

The fluid-based page module has hard-coded labels
within the GridColumnItem class, which is not possible
to override in templates right now. Instead,
f:translate viewhelper is used in this case.

In addition, the PageActions and the ContextMenu get
some additional HTML attributes to clear up logic.

Review

  • Code review CR +2 Done
    • Georg Ringer +2
    • Rachel Foucard +1
  • Verified V +2 Done
    • Georg Ringer +2
    • Rachel Foucard +1
    • core-ci +1 CI

Issues 1

Files 7

Review log 45

  1. Benni Mack uploaded patch set 1 09/16/21, 10:03

  2. Rachel Foucard voted on patch set 1 V +1 CR +1 09/16/21, 10:16

  3. core-ci voted on patch set 1 V +1 09/16/21, 10:18 Core CI is happy: https://gitlab.typo3.org/typo3/CI/cms/-/pipelines/16787

  4. Georg Ringer voted on patch set 1 V +2 CR +2 09/16/21, 10:34

  5. Georg Ringer merged patch set 2 09/16/21, 10:34