71102[TASK] Remove Environment::getFrameworkBasePath where easily possible
Commit message
Review
-
Code review CR +2 Done
- Helmut Hummel +2
- Oli Bartsch +1
- Benni Mack +1
-
Verified V +2 Done
- Helmut Hummel +2
- Oli Bartsch +1
- Benni Mack +1
- core-ci +1 CI
Issues 1
Files 8
- typo3/sysext/core/Classes/Configuration/ConfigurationManager.php4+6 −6
- typo3/sysext/core/Classes/Controller/ErrorPageController.php+3 −4
- typo3/sysext/core/Tests/Unit/Localization/Parser/XliffParserTest.php+1 −1
- typo3/sysext/core/Tests/Unit/Utility/GeneralUtilityTest.php+14 −31
- typo3/sysext/frontend/Tests/Functional/Imaging/GifBuilderTest.php+1 −1
- typo3/sysext/frontend/Tests/Unit/ContentObject/FluidTemplateContentObjectTest.php+2 −2
- typo3/sysext/install/Classes/Controller/EnvironmentController.php+17 −16
- typo3/sysext/install/Classes/FolderStructure/DefaultFactory.php+13 −11
Review log 1115
-
Helmut Hummel uploaded patch set 1 09/16/21, 12:00
-
core-ci voted on patch set 1 V -1 09/16/21, 12:17 Core CI is not happy: https://gitlab.typo3.org/typo3/CI/cms/-/pipelines/16795
-
Helmut Hummel updated the commit message in patch set 2 09/18/21, 11:27
-
core-ci voted on patch set 2 V -1 09/18/21, 11:51 Core CI is not happy: https://gitlab.typo3.org/typo3/CI/cms/-/pipelines/16902
-
Helmut Hummel uploaded patch set 3 09/18/21, 12:00
-
core-ci voted on patch set 3 V -1 09/18/21, 12:04 Core CI is not happy: https://gitlab.typo3.org/typo3/CI/cms/-/pipelines/16903
-
Helmut Hummel uploaded patch set 4 09/18/21, 14:33
-
core-ci voted on patch set 4 V +1 09/18/21, 14:50 Core CI is happy: https://gitlab.typo3.org/typo3/CI/cms/-/pipelines/16908
-
Benni Mack voted on patch set 4 V +1 CR +1 09/21/21, 10:13
-
Oli Bartsch commented on patch set 4 09/21/21, 12:38
-
Benni Mack commented on patch set 4 09/21/21, 14:14
ConfigurationManager.php:44Replyyeah, I think we should remove it below as well. -
Benni Mack commented on patch set 4 09/21/21, 14:19
ConfigurationManager.php:44ReplyHowever, the Description.yaml is only used for reading purposes in the install tool when EXT: syntax can be resolved (so it is OK to use here), the other places are called very very very early within the Bootstrap process. -
Oli Bartsch commented on patch set 4 V +1 CR +1 09/21/21, 14:20
ConfigurationManager.php:44ReplyAck -
Helmut Hummel voted on patch set 4 V +2 CR +2 09/21/21, 15:58
-
Helmut Hummel merged patch set 5 09/21/21, 15:59
ConfigurationManager.php:44