Review main Merged

71102[TASK] Remove Environment::getFrameworkBasePath where easily possible

Helmut Hummel CR +2 V +2 Normal +57 −72 updated 09/21/21, 15:59

Commit message

Environment::getFrameworkBasePath() API was created
under the assumption that TYPO3 core extensions are always installed
in a dedicated but fixed folder (typo3/sysext).

Additionally this folder is assumed to be publicly accessible
through a web server.

Therefore this API is used in two contexts.
1. To resolve and check file system paths
2. To create URLs to public resources

To at some point achieve the goal to allow all TYPO3 extensions
to be installed in arbitrary locations (a configurable
vendor folder), usage of such API must be removed.

As a first step all usages are removed, that reference
files within the boundaries of one extensions.
Relative paths (relative to the file that references) are used
instead, or, where possible EXT: syntax

Review

  • Code review CR +2 Done
    • Helmut Hummel +2
    • Oli Bartsch +1
    • Benni Mack +1
  • Verified V +2 Done
    • Helmut Hummel +2
    • Oli Bartsch +1
    • Benni Mack +1
    • core-ci +1 CI

Issues 1

Files 8

Review log 1115

  1. Helmut Hummel uploaded patch set 1 09/16/21, 12:00

  2. core-ci voted on patch set 1 V -1 09/16/21, 12:17 Core CI is not happy: https://gitlab.typo3.org/typo3/CI/cms/-/pipelines/16795

  3. Helmut Hummel updated the commit message in patch set 2 09/18/21, 11:27

  4. core-ci voted on patch set 2 V -1 09/18/21, 11:51 Core CI is not happy: https://gitlab.typo3.org/typo3/CI/cms/-/pipelines/16902

  5. Helmut Hummel uploaded patch set 3 09/18/21, 12:00

  6. core-ci voted on patch set 3 V -1 09/18/21, 12:04 Core CI is not happy: https://gitlab.typo3.org/typo3/CI/cms/-/pipelines/16903

  7. Helmut Hummel uploaded patch set 4 09/18/21, 14:33

  8. core-ci voted on patch set 4 V +1 09/18/21, 14:50 Core CI is happy: https://gitlab.typo3.org/typo3/CI/cms/-/pipelines/16908

  9. Benni Mack voted on patch set 4 V +1 CR +1 09/21/21, 10:13

  10. Oli Bartsch commented on patch set 4 09/21/21, 12:38

    ConfigurationManager.php:44

    What is the reason for not using EXT: here like we do for `$defaultConfigurationDescriptionFile`?
  11. Benni Mack commented on patch set 4 09/21/21, 14:14

    ConfigurationManager.php:44 Reply

    yeah, I think we should remove it below as well.
  12. Benni Mack commented on patch set 4 09/21/21, 14:19

    ConfigurationManager.php:44 Reply

    However, the Description.yaml is only used for reading purposes in the install tool when EXT: syntax can be resolved (so it is OK to use here), the other places are called very very very early within the Bootstrap process.
  13. Oli Bartsch commented on patch set 4 V +1 CR +1 09/21/21, 14:20

    ConfigurationManager.php:44 Reply

    Ack
  14. Helmut Hummel voted on patch set 4 V +2 CR +2 09/21/21, 15:58

  15. Helmut Hummel merged patch set 5 09/21/21, 15:59