Review main Merged

71103[TASK] Better behaviour for “Unused elements” after a drag & drop

Rachel Foucard CR +2 V +2 Easy +5 −5 updated 09/16/21, 13:11

Commit message

The unused elements in the page module have a specific styling
(orange heading). When the items are drag&drop'ed into an active
colPos, they previously kept their unused styling.

This change gives the "Unused elements" a global warning background
and removes the warning style from the content items so that they don't
stay orange after a drag and drop in a real colPos.

Review

  • Code review CR +2 Done
    • Benni Mack +2
    • Jonas Eberle +1
  • Verified V +2 Done
    • Benni Mack +2
    • Jonas Eberle +1
    • core-ci +1 CI

Issues 1

Files 3

Review log 57

  1. Rachel Foucard uploaded patch set 1 09/16/21, 12:13

  2. core-ci voted on patch set 1 V -1 09/16/21, 12:26 Core CI is not happy: https://gitlab.typo3.org/typo3/CI/cms/-/pipelines/16796

  3. Benni Mack uploaded patch set 2 09/16/21, 12:51

  4. core-ci voted on patch set 2 V +1 09/16/21, 13:05 Core CI is happy: https://gitlab.typo3.org/typo3/CI/cms/-/pipelines/16799

  5. Jonas Eberle voted on patch set 2 V +1 CR +1 09/16/21, 13:06

  6. Benni Mack voted on patch set 2 V +2 CR +2 09/16/21, 13:11

  7. Benni Mack merged patch set 3 09/16/21, 13:11