Review main Merged

71104[BUGFIX] Align pagination in recycler and workspaces

Jochen Roth CR +2 V +2 Normal +26 −38 updated 09/17/21, 00:08

Commit message

EXT:recycler and EXT:workspaces use nearly the same
code for their custom JavaScript based pagination.

Therefore, both are adjusted accordingly.

All buttons are now always equal height, since
the "page-link" class now uses the full parent
container space.

The prev / next buttons now use the TYPO3 icon
element instead of font awesome, making additional
classes superfluous.

All buttons are now "buttons", since they do not
contain a target. This also brings previously
missing user agent styles, such as cursor:pointer.
Also the full area is now clickable.

Additionally, a left over code block from #81086
is removed in the Recycler JavaScript module.

Review

  • Code review CR +2 Done
    • Oli Bartsch +2
    • Christian Kuhn +1
  • Verified V +2 Done
    • Oli Bartsch +2
    • Christian Kuhn +1
    • core-ci +1 CI

Issues 1

Files 7

Review log 1218

  1. Jochen Roth uploaded patch set 1 09/16/21, 14:36

  2. Jochen Roth uploaded patch set 2 09/16/21, 14:40

  3. core-ci voted on patch set 1 V -1 09/16/21, 14:56 Core CI is not happy: https://gitlab.typo3.org/typo3/CI/cms/-/pipelines/16807

  4. core-ci voted on patch set 2 V -1 09/16/21, 15:04 Core CI is not happy: https://gitlab.typo3.org/typo3/CI/cms/-/pipelines/16808

  5. Jochen Roth uploaded patch set 3 09/16/21, 17:30

  6. Jochen Roth uploaded patch set 4 09/16/21, 17:41

  7. core-ci voted on patch set 3 V +1 09/16/21, 17:45 Core CI is happy: https://gitlab.typo3.org/typo3/CI/cms/-/pipelines/16824

  8. core-ci voted on patch set 4 V +1 09/16/21, 17:55 Core CI is happy: https://gitlab.typo3.org/typo3/CI/cms/-/pipelines/16826

  9. Oli Bartsch commented on patch set 4 CR -1 09/16/21, 20:21

    _recycler.scss:13

    The problem is that the a tags do not have a target. Otherwise browsers would automatically set cursor:pointer. See for example the other paginations, e.g. in extension manager.

    Recycler.ts:182

    This might no longer work

    Recycler.ts:532

    EXT:workspaces is using nearly the same code. We might change it there as well.

    Recycler.ts:572

    This might no longer work
  10. Oli Bartsch uploaded patch set 5 09/16/21, 21:55

  11. Oli Bartsch commented on patch set 5 V +1 CR +1 09/16/21, 21:56

    _recycler.scss:13 Reply

    Done

    Recycler.ts:182 Reply

    Done

    Recycler.ts:532 Reply

    Done

    Recycler.ts:572 Reply

    Done
  12. core-ci voted on patch set 5 V -1 09/16/21, 22:09 Core CI is not happy: https://gitlab.typo3.org/typo3/CI/cms/-/pipelines/16834

  13. Oli Bartsch uploaded patch set 6 09/16/21, 22:29

  14. core-ci voted on patch set 6 V +1 09/16/21, 22:46 Core CI is happy: https://gitlab.typo3.org/typo3/CI/cms/-/pipelines/16836

  15. Oli Bartsch voted on patch set 6 V +1 CR +1 09/16/21, 23:02

  16. Christian Kuhn voted on patch set 6 V +1 CR +1 09/16/21, 23:30

  17. Oli Bartsch voted on patch set 6 V +2 CR +2 09/17/21, 00:08

  18. Oli Bartsch merged patch set 7 09/17/21, 00:08