Review main Merged

71105[BUGFIX] Fix behaviour when dragging a content in the page module

Rachel Foucard CR +2 V +2 Easy +19 −7 updated 09/17/21, 20:47

Commit message

The drop zones added space when they appear during a drag and drop
action and it changed the mouse position. Also each content had a
“new content” button relative to it and this button was dragged
with it. This fixes both problems.

Review

  • Code review CR +2 Done
    • Benni Mack +2
    • Jonas Eberle +1
  • Verified V +2 Done
    • Benni Mack +2
    • Jonas Eberle +1
    • Oliver Hader +1
    • core-ci +1 CI

Issues 1

Files 2

Review log 1420

  1. Rachel Foucard uploaded patch set 1 09/16/21, 16:05

  2. Jonas Eberle updated the commit message in patch set 2 09/16/21, 16:18

  3. core-ci voted on patch set 1 V -1 09/16/21, 16:19 Core CI is not happy: https://gitlab.typo3.org/typo3/CI/cms/-/pipelines/16812

  4. Rachel Foucard uploaded patch set 3 09/16/21, 16:23

  5. Jonas Eberle updated the commit message in patch set 4 09/16/21, 16:25

  6. core-ci voted on patch set 2 V -1 09/16/21, 16:32 Core CI is not happy: https://gitlab.typo3.org/typo3/CI/cms/-/pipelines/16814

  7. core-ci voted on patch set 3 V -1 09/16/21, 16:37 Core CI is not happy: https://gitlab.typo3.org/typo3/CI/cms/-/pipelines/16815

  8. Jonas Eberle uploaded patch set 5 09/16/21, 16:42

  9. core-ci voted on patch set 4 V -1 09/16/21, 16:43 Core CI is not happy: https://gitlab.typo3.org/typo3/CI/cms/-/pipelines/16816

  10. Jonas Eberle voted on patch set 5 V +1 09/16/21, 16:52

  11. core-ci voted on patch set 5 V +1 09/16/21, 16:55 Core CI is happy: https://gitlab.typo3.org/typo3/CI/cms/-/pipelines/16817

  12. Jonas Eberle voted on patch set 5 CR +1 09/16/21, 16:56

  13. Benni Mack uploaded patch set 6 09/17/21, 08:09

  14. core-ci voted on patch set 6 V +1 09/17/21, 08:22 Core CI is happy: https://gitlab.typo3.org/typo3/CI/cms/-/pipelines/16856

  15. Benni Mack voted on patch set 6 V +1 09/17/21, 08:23

  16. Benni Mack voted on patch set 6 CR +1 09/17/21, 08:23

  17. Jonas Eberle voted on patch set 6 V +1 CR +1 09/17/21, 08:40

  18. Benni Mack voted on patch set 6 V +2 CR +2 09/17/21, 08:47

  19. Benni Mack merged patch set 7 09/17/21, 08:47

  20. Oliver Hader voted on patch set 7 V +1 09/17/21, 20:47