Review main Abandoned

71108[TASK] Add a context menu button to content elements in backend

Rachel Foucard CR 0 V 0 Easy +10 −1 updated 11/11/21, 14:00

Commit message

New users can’t guess they can click on the icon of a content to get
the context menu. For a better overview, a new button for the content
element context menu is added in the content element header button bar.

Review

  • Code review CR 0
  • Verified V 0

Issues 1

Files 3

Review log 1012

  1. Rachel Foucard uploaded patch set 1 09/16/21, 17:28

  2. core-ci voted on patch set 1 V -1 09/16/21, 17:39 Core CI is not happy: https://gitlab.typo3.org/typo3/CI/cms/-/pipelines/16823

  3. Jonas Eberle voted on patch set 1 V +1 CR +1 09/16/21, 17:58

  4. Jonas Eberle uploaded patch set 2 09/16/21, 18:03

  5. core-ci voted on patch set 2 V +1 09/16/21, 18:17 Core CI is happy: https://gitlab.typo3.org/typo3/CI/cms/-/pipelines/16828

  6. Jonas Eberle voted on patch set 2 V +1 CR +1 09/16/21, 18:24

  7. Christian Kuhn commented on patch set 2 CR -1 09/16/21, 20:15

    * The context menu is basically on all icons throughout the entire interface. Changing that only in the page module by adding another button is no improvement. * The icon with 3 dots does not say anything and is used in the list module differently already. * The batch does not work well, the context menu does not properly close and sometimes pops up an weird places.
  8. Martin Kutschker commented on patch set 2 09/17/21, 09:17

    Reply

    While by no means a standard a button or icon with 3 dots signifies usally a submenu only rarely it is used to tell the user about a modal with options. There is a reason why Rachel wants the extra buttons. But I agree with you that adding then just here makes the BE inconsistent. Other applications have a toggle so that a user can hide/show help icons throughout the UI. In the long run (v12?) this is IMHO the way to go.
  9. Peter Kraume commented on patch set 2 09/17/21, 11:42

    Maybe the new context menu button is a little bit inconsistent but from an editors perspective it makes perfect sense. From the many editor trainings I did in the past, I've learned that no editor ever guessed that there is a hidden context menu for the content elements.
  10. Rachel Foucard commented on patch set 2 09/17/21, 11:46

    Hi

    Reply Unresolved

    Hi Christian, hi Martin, thank you very much for your feed back. I have added some additional information and explanation in the forge ticket. I hope it will give answers to your questions.
  11. Martin Kutschker commented on patch set 2 09/17/21, 16:37

    Reply Unresolved

    While Christian arguments that in the BE there are so many context menus that we don't need any hints to find them I agree with Peter that some are not so likely to be found. Not every editor has the habit to click on any UI element to find out what they do or if they have any context menu. So in case the delete buttons disappears I'm in favour of a dedicated "more options". Ideally in a style that can be used in other places within the BE in the future.
  12. Benni Mack abandoned the change 11/11/21, 14:00

    abandoned for the time being, the patch for the pilot project is https://review.typo3.org/c/Packages/TYPO3.CMS/+/71965