Review main Abandoned

71109[TASK] Remove the delete button from the page module content grid

Rachel Foucard CR 0 V 0 Easy +0 −10 updated 11/11/21, 14:00

Commit message

Deleting content is a less common action than editing or hiding it.
In an effort to simplify the page grid UI, this action can be removed
from the page content preview and shown only in the overflow menu.
This also prevents the issue where the user intends to hide the content
element but accidentally uses the delete icon instead.
Solution description: Simplify the page module interface by removing
the lesser-used delete icon.

Review

  • Code review CR 0
  • Verified V 0

Issues 1

Files 1

Review log 910

  1. Rachel Foucard uploaded patch set 1 09/16/21, 17:41

  2. Jonas Eberle voted on patch set 1 V +1 CR +1 09/16/21, 17:54

  3. core-ci voted on patch set 1 V +1 09/16/21, 18:00 Core CI is happy: https://gitlab.typo3.org/typo3/CI/cms/-/pipelines/16827

  4. Christian Kuhn commented on patch set 1 CR -1 09/16/21, 20:23

    Hey Rachel. Thanks for your patch aiming to improve the page module interface. Maybe you could clear up an issue I have here: You say you want to declutter the interface by dropping an icon that tells with it's iconography exactly what it will do. You postulate editors don't need to delete content often. I disagree on that. And then you propose to substitute the very clear wastebin icon with https://review.typo3.org/c/Packages/TYPO3.CMS/+/71108 by a new icon that says nothing, and adding a functionality that is already there on a different icon throughout the backend. Both patches don't look like true ux improvements at it's current state to me. Would you like to clearify the bigger picture behind that?
  5. Martin Kutschker commented on patch set 1 09/17/21, 09:23

    Reply

    I never had the impression that the page module showed too many icons at content element level. But this is highly subjective. The actions I use most are hiding/showing, reordering and getting infos about the CE. Other users may never need the info icon. Reminds me a bit of the save&close button issue. In every instance we have we instal the extension because save&close is THE most useful button :)
  6. Markus Klein commented on patch set 1 09/17/21, 09:58

    Reply

    Full ACK with Martin
  7. Markus Klein commented on patch set 1 09/17/21, 10:07

    My wish is to have the important commands as single click: - new content - hide content - delete content
  8. Peter Kraume commented on patch set 1 09/17/21, 11:34

    I would not hide the delete button in the context menu, no matter if there is the new button with the dots instead. I think this leads to the problem that content will only be hidden and not deleted.
  9. Rachel Foucard commented on patch set 1 09/17/21, 11:53

    Reply Unresolved

    Hi Christian, Martin, Markus and Peter :) thank you very much for your feed back. I have added some additional information and explanation in the forge ticket. I hope it will give answers to your questions.
  10. Benni Mack abandoned the change 11/11/21, 14:00

    abandoned for the time being, the patch for the pilot project is https://review.typo3.org/c/Packages/TYPO3.CMS/+/71965