71114[WIP][TASK] Add return types for internal / test methods
Commit message
Review
-
Code review CR 0
-
Verified V 0
Issues 1
Files 20
- typo3/sysext/core/Resources/PHP/ClassMapGenerator.php+1 −1
- typo3/sysext/core/Tests/Functional/Fixtures/Extensions/irre_tutorial/Classes/Controller/AbstractController.php+1 −1
- typo3/sysext/core/Tests/Functional/Fixtures/Extensions/irre_tutorial/Classes/Domain/Model/Content.php+3 −3
- typo3/sysext/core/Tests/Functional/Fixtures/Extensions/irre_tutorial/Classes/Domain/Model/Hotel.php+3 −3
- typo3/sysext/core/Tests/Functional/Fixtures/Extensions/irre_tutorial/Classes/Domain/Model/Offer.php+3 −3
- typo3/sysext/core/Tests/Functional/Fixtures/Extensions/test_datahandler/Classes/Tca/SelectElementItems.php+1 −1
- typo3/sysext/extbase/Classes/DomainObject/AbstractDomainObject.php+2 −2
- typo3/sysext/extbase/Classes/Validation/Validator/AbstractValidator.php+1 −1
- typo3/sysext/extbase/Tests/Functional/Fixtures/Extensions/blog_example/Classes/Controller/ContentController.php+0 −3
- typo3/sysext/extbase/Tests/Functional/Fixtures/Extensions/blog_example/Classes/Domain/Model/Administrator.php+1 −1
- typo3/sysext/extbase/Tests/Functional/Fixtures/Extensions/blog_example/Classes/Domain/Model/Blog.php1+2 −2
- typo3/sysext/extbase/Tests/Functional/Fixtures/Extensions/blog_example/Classes/Domain/Model/Category.php+1 −1
- typo3/sysext/extbase/Tests/Functional/Fixtures/Extensions/blog_example/Classes/Domain/Model/Comment.php+1 −1
- typo3/sysext/extbase/Tests/Functional/Fixtures/Extensions/blog_example/Classes/Domain/Model/Info.php+1 −1
- typo3/sysext/extbase/Tests/Functional/Fixtures/Extensions/blog_example/Classes/Domain/Model/Post.php1+8 −8
- typo3/sysext/extbase/Tests/Functional/Fixtures/Extensions/blog_example/Classes/Domain/Model/Tag.php+1 −1
- typo3/sysext/extbase/Tests/Functional/Fixtures/Extensions/blog_example/Classes/Domain/Model/TtContent.php+3 −3
- typo3/sysext/extbase/Tests/Functional/Mvc/Controller/Fixture/Extension/action_controller_argument_test/Classes/Domain/Model/Model.php+2 −2
- typo3/sysext/extbase/Tests/Functional/Mvc/Controller/Fixture/Extension/action_controller_argument_test/Classes/Domain/Model/ModelDto.php+2 −2
- typo3/sysext/extbase/Tests/Functional/Mvc/Controller/Fixture/Extension/action_controller_test/Classes/Domain/Model/Model.php+2 −2
Review log 814
-
Benni Mack uploaded patch set 1 09/17/21, 07:11
-
core-ci voted on patch set 1 V -1 09/17/21, 07:14 Core CI is not happy: https://gitlab.typo3.org/typo3/CI/cms/-/pipelines/16853
-
Benni Mack uploaded patch set 2 09/17/21, 07:19
-
core-ci voted on patch set 2 V -1 09/17/21, 09:22 Core CI is not happy: https://gitlab.typo3.org/typo3/CI/cms/-/pipelines/16854
-
Benni Mack rebased onto patch set 3 09/21/21, 15:17
-
core-ci voted on patch set 3 V -1 09/21/21, 17:26 Core CI is not happy: https://gitlab.typo3.org/typo3/CI/cms/-/pipelines/16995
-
Benni Mack uploaded patch set 4 09/22/21, 07:34
-
core-ci voted on patch set 4 V -1 09/22/21, 09:37 Core CI is not happy: https://gitlab.typo3.org/typo3/CI/cms/-/pipelines/17018
-
Wouter Wolters commented on patch set 4 09/22/21, 10:44
Post.php:294UnresolvedPerson|null should be the return type -
Wouter Wolters uploaded patch set 5 09/23/21, 20:50
-
core-ci voted on patch set 5 V -1 09/23/21, 22:53 Core CI is not happy: https://gitlab.typo3.org/typo3/CI/cms/-/pipelines/17126
-
Benni Mack rebased onto patch set 6 10/01/21, 13:32
-
core-ci voted on patch set 6 V -1 10/01/21, 15:43 Core CI is not happy: https://gitlab.typo3.org/typo3/CI/cms/-/pipelines/17435
-
Benni Mack abandoned the change 11/04/21, 11:20
will abandon this change for now, can't get it fixed
Blog.php:248Unresolved