Review main Abandoned

71114[WIP][TASK] Add return types for internal / test methods

Benni Mack CR 0 V 0 Normal +39 −42 updated 11/04/21, 11:20

Commit message

This change eases the pain for updating to PHP 8 and Symfony 6
by using symfony/error-handler's "patch-type-declarations" solution.

See https://wouterj.nl/2021/09/symfony-6-native-typing for more details
on how this procedure works.

Used CLI call:
SYMFONY_PATCH_TYPE_DECLARATIONS="force=1&php=7.4" ./bin/patch-type-declarations

This change solely touches final and internal methods and thus
isn't intrusive unlike possible further changes.

Review

  • Code review CR 0
  • Verified V 0

Issues 1

Files 20

Review log 814

  1. Benni Mack uploaded patch set 1 09/17/21, 07:11

  2. core-ci voted on patch set 1 V -1 09/17/21, 07:14 Core CI is not happy: https://gitlab.typo3.org/typo3/CI/cms/-/pipelines/16853

  3. Benni Mack uploaded patch set 2 09/17/21, 07:19

  4. core-ci voted on patch set 2 V -1 09/17/21, 09:22 Core CI is not happy: https://gitlab.typo3.org/typo3/CI/cms/-/pipelines/16854

  5. Benni Mack rebased onto patch set 3 09/21/21, 15:17

  6. core-ci voted on patch set 3 V -1 09/21/21, 17:26 Core CI is not happy: https://gitlab.typo3.org/typo3/CI/cms/-/pipelines/16995

  7. Benni Mack uploaded patch set 4 09/22/21, 07:34

  8. core-ci voted on patch set 4 V -1 09/22/21, 09:37 Core CI is not happy: https://gitlab.typo3.org/typo3/CI/cms/-/pipelines/17018

  9. Wouter Wolters commented on patch set 4 09/22/21, 10:44

    Blog.php:248 Unresolved

    this one won't work.

    Post.php:294 Unresolved

    Person|null should be the return type
  10. Wouter Wolters uploaded patch set 5 09/23/21, 20:50

  11. core-ci voted on patch set 5 V -1 09/23/21, 22:53 Core CI is not happy: https://gitlab.typo3.org/typo3/CI/cms/-/pipelines/17126

  12. Benni Mack rebased onto patch set 6 10/01/21, 13:32

  13. core-ci voted on patch set 6 V -1 10/01/21, 15:43 Core CI is not happy: https://gitlab.typo3.org/typo3/CI/cms/-/pipelines/17435

  14. Benni Mack abandoned the change 11/04/21, 11:20

    will abandon this change for now, can't get it fixed