Review main Merged

71115[TASK] Unused $uploadedFiles in DataHandler

Christian Kuhn CR +2 V +2 Normal +18 −37 updated 09/18/21, 23:51

Commit message

Variable $uploadedFiles is carried around in
DataHandler through various methods, but is in
fact never used since TCA type=group with
internal_type=file has been dropped in v10.

The patch drops that argument. All method changes
are detail implementations within DataHandler and
either protected or marked @internal, the change
does not raise backwards compatibility issues.

Review

  • Code review CR +2 Done
    • Christian Kuhn +2
    • Stefan Bürk +1
    • Benni Mack +1
  • Verified V +2 Done
    • Christian Kuhn +2
    • Stefan Bürk +1
    • Benni Mack +1
    • core-ci +1 CI

Issues 2

Files 3

Review log 914

  1. Christian Kuhn uploaded patch set 1 09/17/21, 10:25

  2. Christian Kuhn uploaded patch set 2 09/17/21, 10:55

  3. Christian Kuhn uploaded patch set 3 09/17/21, 11:10

  4. Christian Kuhn uploaded patch set 4 09/17/21, 11:32

  5. Christian Kuhn updated the commit message in patch set 5 09/17/21, 11:57

  6. core-ci voted on patch set 2 V -1 09/17/21, 12:02 Core CI is not happy: https://gitlab.typo3.org/typo3/CI/cms/-/pipelines/16865

  7. core-ci voted on patch set 3 V -1 09/17/21, 12:18 Core CI is not happy: https://gitlab.typo3.org/typo3/CI/cms/-/pipelines/16867

  8. core-ci voted on patch set 4 V -1 09/17/21, 12:40 Core CI is not happy: https://gitlab.typo3.org/typo3/CI/cms/-/pipelines/16869

  9. core-ci voted on patch set 5 V -1 09/17/21, 13:06 Core CI is not happy: https://gitlab.typo3.org/typo3/CI/cms/-/pipelines/16873

  10. core-ci voted on patch set 5 V +1 09/17/21, 14:11 Core CI is happy: https://gitlab.typo3.org/typo3/CI/cms/-/pipelines/16873

  11. Benni Mack voted on patch set 5 V +1 CR +1 09/18/21, 18:30

  12. Stefan Bürk voted on patch set 5 V +1 CR +1 09/18/21, 22:06

  13. Christian Kuhn voted on patch set 5 V +2 CR +2 09/18/21, 23:51

  14. Christian Kuhn merged patch set 6 09/18/21, 23:51