71117[TASK] Remove unused code from PageLayoutView
Commit message
Review
-
Code review CR 0
-
Verified V 0
Issues 1
Files 1
Review log 710
-
Benni Mack uploaded patch set 1 09/17/21, 11:02
-
Oli Bartsch voted on patch set 1 V +1 CR +1 09/17/21, 12:00
-
core-ci voted on patch set 1 V -1 09/17/21, 12:10 Core CI is not happy: https://gitlab.typo3.org/typo3/CI/cms/-/pipelines/16866
-
Benni Mack rebased onto patch set 2 09/17/21, 12:53
-
core-ci voted on patch set 2 V -1 09/17/21, 13:17 Core CI is not happy: https://gitlab.typo3.org/typo3/CI/cms/-/pipelines/16875
-
core-ci voted on patch set 2 V +1 09/17/21, 20:17 Core CI is happy: https://gitlab.typo3.org/typo3/CI/cms/-/pipelines/16875
-
Oli Bartsch voted on patch set 2 V +1 CR +1 09/17/21, 20:26
-
Georg Ringer commented on patch set 2 CR -1 09/20/21, 06:08
I don't see any benefit by removing parts of an unused class. Just keep it as a whole and avoid troubles for extension authors who do strange things. No need to do that in this phase of 11. Leave it and remove it in 12 as promised -
Benni Mack commented on patch set 2 09/20/21, 07:24
Unresolved
Hey Georg, this change mostly came out the fact that the "Fluid-based Page Module" feature introduced in TYPO3 v10 did not call the new PSR-14 events, introduced in TYPO3 v10 as well, see https://review.typo3.org/c/Packages/TYPO3.CMS/+/71118 Fine for me keeping the code though for another couple of weeks. -
Benni Mack abandoned the change 09/21/21, 06:42
will do in v12