Review main Merged

71118[BUGFIX] Restore SectionMarkupGenerated events

Oli Bartsch CR +2 V +2 Hard +223 −82 updated 09/20/21, 19:20

Commit message

With #88921 new events were introduced, which allowed
to add additional markup to the columns in page layout.

Those events however were never implemented in the
fluid based page module. Making them useless in v11,
since PageLayoutView can no longer be used.

This patch therefore adds the events to the fluid based
page module. Due to the changed functionality in the
new code base, the events are extended and some
methods are deprecated.

A side effect from the fluid based page module is, that
the events do now take effect in both modes, columns mode
and languages mode, as well as for defLangBinding.

Review

  • Code review CR +2 Done
    • Georg Ringer +2
    • Benni Mack +1
  • Verified V +2 Done
    • Georg Ringer +2
    • Benni Mack +1
    • core-ci +1 CI

Issues 2

Files 10

Review log 610

  1. Oli Bartsch uploaded patch set 1 09/17/21, 11:17

  2. Oli Bartsch uploaded patch set 2 09/17/21, 11:44

  3. core-ci voted on patch set 1 V -1 09/17/21, 12:42 Core CI is not happy: https://gitlab.typo3.org/typo3/CI/cms/-/pipelines/16868

  4. core-ci voted on patch set 2 V -1 09/17/21, 12:57 Core CI is not happy: https://gitlab.typo3.org/typo3/CI/cms/-/pipelines/16872

  5. core-ci commented on patch set 2 09/17/21, 20:24 Core CI is not happy: https://gitlab.typo3.org/typo3/CI/cms/-/pipelines/16872

  6. Oli Bartsch uploaded patch set 3 09/17/21, 20:36

  7. core-ci voted on patch set 3 V +1 09/17/21, 20:52 Core CI is happy: https://gitlab.typo3.org/typo3/CI/cms/-/pipelines/16893

  8. Benni Mack voted on patch set 3 V +1 CR +1 09/20/21, 14:38

  9. Georg Ringer voted on patch set 3 V +2 CR +2 09/20/21, 19:20

  10. Georg Ringer merged patch set 4 09/20/21, 19:20