Review main Merged

71119[TASK] Substitute inline onclick events for ShortcutMenu

Oliver Hader CR +2 V +2 Normal +100 −37 updated 09/20/21, 08:29

Commit message

Substitutes inline `onclick` events for `ShortcutMenu` invocations
in the backend user interface with corresponding HTML attributes
handled by `ActionDispatcher.ts`.

Review

  • Code review CR +2 Done
    • Oli Bartsch +2
    • Benjamin Franzke +1
  • Verified V +2 Done
    • Oli Bartsch +2
    • Benjamin Franzke +1
    • core-ci +1 CI

Issues 1

Files 14

Review log 1625

  1. Oliver Hader uploaded patch set 1 09/17/21, 11:33

  2. Oliver Hader wrote 09/17/21, 11:35

    Topic set to inline-javascript
  3. Oliver Hader updated the commit message in patch set 2 09/17/21, 11:35

  4. core-ci voted on patch set 1 V -1 09/17/21, 12:44 Core CI is not happy: https://gitlab.typo3.org/typo3/CI/cms/-/pipelines/16870

  5. core-ci voted on patch set 2 V -1 09/17/21, 12:52 Core CI is not happy: https://gitlab.typo3.org/typo3/CI/cms/-/pipelines/16871

  6. core-ci commented on patch set 2 09/17/21, 13:20 Core CI is not happy: https://gitlab.typo3.org/typo3/CI/cms/-/pipelines/16871

  7. core-ci voted on patch set 2 V +1 09/17/21, 13:26 Core CI is happy: https://gitlab.typo3.org/typo3/CI/cms/-/pipelines/16871

  8. Markus Klein voted on patch set 2 CR +1 09/17/21, 15:25

  9. Benjamin Franzke uploaded patch set 3 09/17/21, 15:25

  10. core-ci voted on patch set 3 V +1 09/17/21, 15:45 Core CI is happy: https://gitlab.typo3.org/typo3/CI/cms/-/pipelines/16885

  11. Markus Klein voted on patch set 3 CR +1 09/17/21, 17:19

  12. Oli Bartsch commented on patch set 3 V -1 09/17/21, 20:56

    When adding a bookmark, the shortcut button is no longer automatically disabled. Will have a look.
  13. Oliver Hader commented on patch set 3 09/17/21, 21:00

    Reply

    Good catch, I see now when comparing the code. I did not realize that additional `this`... Probably something for `ActionDispatcher` then...
  14. Oliver Hader uploaded patch set 4 09/17/21, 21:32

  15. Oliver Hader uploaded patch set 5 09/17/21, 21:34

  16. core-ci voted on patch set 4 V +1 09/17/21, 21:48 Core CI is happy: https://gitlab.typo3.org/typo3/CI/cms/-/pipelines/16895

  17. core-ci voted on patch set 5 V +1 09/17/21, 21:50 Core CI is happy: https://gitlab.typo3.org/typo3/CI/cms/-/pipelines/16896

  18. Oliver Hader uploaded patch set 6 09/17/21, 21:59

  19. Oliver Hader commented on patch set 6 V -1 09/17/21, 22:03

    State-handling still needs some work
  20. core-ci voted on patch set 6 V +1 09/17/21, 22:17 Core CI is happy: https://gitlab.typo3.org/typo3/CI/cms/-/pipelines/16897

  21. Oliver Hader uploaded patch set 7 09/18/21, 07:35

  22. core-ci voted on patch set 7 V +1 09/18/21, 07:52 Core CI is happy: https://gitlab.typo3.org/typo3/CI/cms/-/pipelines/16901

  23. Benjamin Franzke voted on patch set 7 V +1 CR +1 09/18/21, 11:34

  24. Oli Bartsch voted on patch set 7 V +2 CR +2 09/20/21, 08:29

  25. Oli Bartsch merged patch set 8 09/20/21, 08:29