71119[TASK] Substitute inline onclick events for ShortcutMenu
Commit message
Review
-
Code review CR +2 Done
- Oli Bartsch +2
- Benjamin Franzke +1
-
Verified V +2 Done
- Oli Bartsch +2
- Benjamin Franzke +1
- core-ci +1 CI
Issues 1
Files 14
- Build/Sources/TypeScript/backend/Resources/Public/TypeScript/Toolbar/ShortcutMenu.ts+8 −4
- Build/Sources/TypeScript/backend/Resources/Public/TypeScript/ActionDispatcher.ts+23 −3
- typo3/sysext/backend/Classes/Template/Components/Buttons/Action/ShortcutButton.php+15 −10
- typo3/sysext/backend/Classes/Template/ModuleTemplate.php+18 −9
- typo3/sysext/backend/Resources/Public/JavaScript/Toolbar/ShortcutMenu.js+1 −1
- typo3/sysext/backend/Resources/Public/JavaScript/ActionDispatcher.js+1 −1
- typo3/sysext/backend/Tests/Functional/Template/Components/Buttons/Action/ShortcutButtonTest.php+20 −2
- typo3/sysext/backend/Tests/Functional/Template/Fixtures/RecordList.html+2 −1
- typo3/sysext/backend/Tests/Functional/Template/Fixtures/RecordListCopyToClipboard.html+2 −1
- typo3/sysext/backend/Tests/Functional/Template/Fixtures/RecordListSingleTable.html+2 −1
- typo3/sysext/backend/Tests/Functional/Template/Fixtures/RecordListSingleTableCopyToClipboard.html+2 −1
- typo3/sysext/backend/Tests/Functional/Template/Fixtures/SpecialRouteIdentifier.html+2 −1
- typo3/sysext/backend/Tests/Functional/Template/Fixtures/SpecialRouteIdentifierWithArguments.html+2 −1
- typo3/sysext/backend/Tests/Functional/Template/Fixtures/SpecialRouteIdentifierWithArgumentsCopyToClipboard.html+2 −1
Review log 1625
-
Oliver Hader uploaded patch set 1 09/17/21, 11:33
-
Oliver Hader wrote 09/17/21, 11:35
Topic set to inline-javascript -
Oliver Hader updated the commit message in patch set 2 09/17/21, 11:35
-
core-ci voted on patch set 1 V -1 09/17/21, 12:44 Core CI is not happy: https://gitlab.typo3.org/typo3/CI/cms/-/pipelines/16870
-
core-ci voted on patch set 2 V -1 09/17/21, 12:52 Core CI is not happy: https://gitlab.typo3.org/typo3/CI/cms/-/pipelines/16871
-
core-ci commented on patch set 2 09/17/21, 13:20 Core CI is not happy: https://gitlab.typo3.org/typo3/CI/cms/-/pipelines/16871
-
core-ci voted on patch set 2 V +1 09/17/21, 13:26 Core CI is happy: https://gitlab.typo3.org/typo3/CI/cms/-/pipelines/16871
-
Markus Klein voted on patch set 2 CR +1 09/17/21, 15:25
-
Benjamin Franzke uploaded patch set 3 09/17/21, 15:25
-
core-ci voted on patch set 3 V +1 09/17/21, 15:45 Core CI is happy: https://gitlab.typo3.org/typo3/CI/cms/-/pipelines/16885
-
Markus Klein voted on patch set 3 CR +1 09/17/21, 17:19
-
Oli Bartsch commented on patch set 3 V -1 09/17/21, 20:56
When adding a bookmark, the shortcut button is no longer automatically disabled. Will have a look. -
Oliver Hader commented on patch set 3 09/17/21, 21:00
Reply
Good catch, I see now when comparing the code. I did not realize that additional `this`... Probably something for `ActionDispatcher` then... -
Oliver Hader uploaded patch set 4 09/17/21, 21:32
-
Oliver Hader uploaded patch set 5 09/17/21, 21:34
-
core-ci voted on patch set 4 V +1 09/17/21, 21:48 Core CI is happy: https://gitlab.typo3.org/typo3/CI/cms/-/pipelines/16895
-
core-ci voted on patch set 5 V +1 09/17/21, 21:50 Core CI is happy: https://gitlab.typo3.org/typo3/CI/cms/-/pipelines/16896
-
Oliver Hader uploaded patch set 6 09/17/21, 21:59
-
Oliver Hader commented on patch set 6 V -1 09/17/21, 22:03
State-handling still needs some work -
core-ci voted on patch set 6 V +1 09/17/21, 22:17 Core CI is happy: https://gitlab.typo3.org/typo3/CI/cms/-/pipelines/16897
-
Oliver Hader uploaded patch set 7 09/18/21, 07:35
-
core-ci voted on patch set 7 V +1 09/18/21, 07:52 Core CI is happy: https://gitlab.typo3.org/typo3/CI/cms/-/pipelines/16901
-
Benjamin Franzke voted on patch set 7 V +1 CR +1 09/18/21, 11:34
-
Oli Bartsch voted on patch set 7 V +2 CR +2 09/20/21, 08:29
-
Oli Bartsch merged patch set 8 09/20/21, 08:29