Review 10.4 Merged

71120[BUGFIX] Avoid TSFE injection into standalone ContentObjectRenderer

Benjamin Franzke CR +2 V +2 Easy +2 −0 updated 09/17/21, 15:29

Commit message

TypoScriptFrontendController might not be available
by the time ContentObjectRenderer instances are created

The constructor argument ContentObjectRenderer is
intended to be used by TypoScriptFrontendController
to inject itself, but not for injecting
TypoScriptFrontendController when ContentObjectRenderer
is created as a standolone instance.

This has already been adapted in the master branch
by #95174 and is therefore backported as a separate
10.4-only fix.

Review

  • Code review CR +2 Done
    • Benjamin Franzke +2
    • Simon Gilli +1
    • Torben Hansen +1
  • Verified V +2 Done
    • Benjamin Franzke +2
    • Simon Gilli +1
    • Torben Hansen +1
    • core-ci +1 CI

Issues 3

Files 1

Review log 56

  1. Benjamin Franzke uploaded patch set 1 09/17/21, 13:26

  2. Simon Gilli voted on patch set 1 V +1 CR +1 09/17/21, 13:29

  3. core-ci voted on patch set 1 V +1 09/17/21, 13:35 Core CI is happy: https://gitlab.typo3.org/typo3/CI/cms/-/pipelines/16878

  4. Torben Hansen voted on patch set 1 V +1 CR +1 09/17/21, 14:26

  5. Benjamin Franzke voted on patch set 1 V +2 CR +2 09/17/21, 15:29

  6. Benjamin Franzke merged patch set 2 09/17/21, 15:29