71121[TASK] Remove inline JavaScript from Install Tool
Commit message
Review
-
Code review CR +2 Done
- Benjamin Franzke +2
- Simon Gilli +1
-
Verified V +2 Done
- Benjamin Franzke +2
- Simon Gilli +1
- core-ci +1 CI
Issues 2
Files 3
Review log 1316
-
Oliver Hader uploaded patch set 1 09/17/21, 14:41
-
Jonas Eberle voted on patch set 1 V +1 CR +1 09/17/21, 14:55
-
core-ci voted on patch set 1 V +1 09/17/21, 15:05 Core CI is happy: https://gitlab.typo3.org/typo3/CI/cms/-/pipelines/16880
-
Benjamin Franzke uploaded patch set 2 09/17/21, 15:08
-
Benjamin Franzke updated the commit message in patch set 3 09/17/21, 15:09
-
Markus Klein commented on patch set 3 09/17/21, 15:19
-
core-ci voted on patch set 3 V +1 09/17/21, 15:23 Core CI is happy: https://gitlab.typo3.org/typo3/CI/cms/-/pipelines/16883
-
Simon Gilli voted on patch set 3 V +1 CR +1 09/17/21, 15:25
-
Benjamin Franzke uploaded patch set 4 09/17/21, 15:36
-
Benjamin Franzke commented on patch set 4 09/17/21, 15:36
Installer.ts:69ReplyAck -
Simon Gilli voted on patch set 4 V +1 CR +1 09/17/21, 15:38
-
core-ci voted on patch set 4 V +1 09/17/21, 15:54 Core CI is happy: https://gitlab.typo3.org/typo3/CI/cms/-/pipelines/16887
-
Benjamin Franzke voted on patch set 4 V +2 CR +2 09/17/21, 15:54
-
Benjamin Franzke merged patch set 5 09/17/21, 15:54
-
Alexander Nitsche commented on patch set 4 09/17/21, 15:57
Installer.ts:66Is there a reason that .t3-install-* is not named .t3js-installer-*? no offense, this is just to know the different usage type. -
Oliver Hader commented on patch set 5 09/17/21, 17:11
Installer.ts:66Reply UnresolvedI did not pay any attention on a potential naming scheme here at all... But you're right, it probably should be streamlined.
Installer.ts:69