Review main Merged

71121[TASK] Remove inline JavaScript from Install Tool

Oliver Hader CR +2 V +2 Easy +20 −2 updated 09/17/21, 17:11

Commit message

Removes inline JavaScript from installer step
"Create Administrative User & Specify Site Name".

Also mark button as type="button" to avoid intercepting
the form submit due to the toggling event handler.

Review

  • Code review CR +2 Done
    • Benjamin Franzke +2
    • Simon Gilli +1
  • Verified V +2 Done
    • Benjamin Franzke +2
    • Simon Gilli +1
    • core-ci +1 CI

Issues 2

Files 3

Review log 1316

  1. Oliver Hader uploaded patch set 1 09/17/21, 14:41

  2. Jonas Eberle voted on patch set 1 V +1 CR +1 09/17/21, 14:55

  3. core-ci voted on patch set 1 V +1 09/17/21, 15:05 Core CI is happy: https://gitlab.typo3.org/typo3/CI/cms/-/pipelines/16880

  4. Benjamin Franzke uploaded patch set 2 09/17/21, 15:08

  5. Benjamin Franzke updated the commit message in patch set 3 09/17/21, 15:09

  6. Markus Klein commented on patch set 3 09/17/21, 15:19

    Installer.ts:69

    Should be $($element.data('toggleTarget')); in alignment to the comment "Since jQuery 3, every two-character sequence .." here https://api.jquery.com/data/
  7. core-ci voted on patch set 3 V +1 09/17/21, 15:23 Core CI is happy: https://gitlab.typo3.org/typo3/CI/cms/-/pipelines/16883

  8. Simon Gilli voted on patch set 3 V +1 CR +1 09/17/21, 15:25

  9. Benjamin Franzke uploaded patch set 4 09/17/21, 15:36

  10. Benjamin Franzke commented on patch set 4 09/17/21, 15:36

    Installer.ts:69 Reply

    Ack
  11. Simon Gilli voted on patch set 4 V +1 CR +1 09/17/21, 15:38

  12. core-ci voted on patch set 4 V +1 09/17/21, 15:54 Core CI is happy: https://gitlab.typo3.org/typo3/CI/cms/-/pipelines/16887

  13. Benjamin Franzke voted on patch set 4 V +2 CR +2 09/17/21, 15:54

  14. Benjamin Franzke merged patch set 5 09/17/21, 15:54

  15. Alexander Nitsche commented on patch set 4 09/17/21, 15:57

    Installer.ts:66

    Is there a reason that .t3-install-* is not named .t3js-installer-*? no offense, this is just to know the different usage type.
  16. Oliver Hader commented on patch set 5 09/17/21, 17:11

    Installer.ts:66 Reply Unresolved

    I did not pay any attention on a potential naming scheme here at all... But you're right, it probably should be streamlined.