71122[BUGFIX] Add missing cookie option on install tool logout
Commit message
Review
-
Code review CR +2 Done
- Christian Kuhn +2
- Markus Klein +1
- Nikita Hovratov +1
-
Verified V +2 Done
- Christian Kuhn +2
- Nikita Hovratov +1
- core-ci +1 CI
Issues 1
Files 3
Review log 3243
Show 1418 earlier messages
-
Simon Gilli uploaded patch set 1 09/17/21, 16:42
-
Oliver Klee commented on patch set 1 09/17/21, 16:55
The issue ID seems to be missing. -
core-ci voted on patch set 1 V +1 09/17/21, 16:59 Core CI is happy: https://gitlab.typo3.org/typo3/CI/cms/-/pipelines/16889
-
Simon Gilli updated the commit message in patch set 2 09/17/21, 17:02
-
Simon Gilli commented on patch set 2 09/17/21, 17:02
Reply
Yeah, had to create one. -
core-ci voted on patch set 2 V +1 09/17/21, 17:16 Core CI is happy: https://gitlab.typo3.org/typo3/CI/cms/-/pipelines/16890
-
Markus Klein voted on patch set 2 CR +1 09/17/21, 17:21
-
Markus Klein commented on patch set 2 V +1 09/17/21, 17:22
good catch -
Oliver Hader commented on patch set 2 CR -1 09/17/21, 17:28
https://www.php.net/manual/en/function.setcookie.php `$options` is not supported in PHP 7.2 (for TYPO3 v10.4, v9.5). See `AbstractUserAuthentication::removeCookie` how it has been implemented there... Can you please dump the error message being shown in the console? Thx. -
Markus Klein commented on patch set 2 09/17/21, 17:32
Reply
German only from v10: Das Cookie "Typo3InstallTool" wird in Zukunft bald abgelehnt werden, da es für das Attribut "SameSite" entweder "None" oder einen ungültigen Wert angibt, ohne das "secure"-Attribut zu verwenden. Weitere Informationen zum "SameSite"-Attribut finden Sie unter https://developer.mozilla.org/docs/Web/HTTP/Headers/Set-Cookie/SameSite. -
Markus Klein commented on patch set 2 V 0 CR 0 09/17/21, 17:36
withdrawing my vote due to the PHP 7.2 issue mentioned by OllyReply
set-cookie Typo3InstallTool=deleted; expires=Thu, 01-Jan-1970 00:00:01 GMT; Max-Age=0; path=/; HttpOnly is the header sent for the /typo3/install.php?install[controller]=maintenance&install[action]=showEnableInstallToolFile request -
Oliver Klee wrote 09/17/21, 19:52
Removed cc Oliver Klee. -
Simon Gilli commented on patch set 2 09/18/21, 09:00
Reply
Good catch, didn't see this is not supported with PHP 7.2. Will check AbstractUserAuthentication... -
Simon Gilli uploaded patch set 3 09/18/21, 12:51
-
Simon Gilli uploaded patch set 4 09/18/21, 12:59
-
Simon Gilli commented on patch set 4 09/18/21, 13:00
Reply
DoneAlso found a missing dependency which is now properly added. -
core-ci voted on patch set 3 V -1 09/18/21, 13:10 Core CI is not happy: https://gitlab.typo3.org/typo3/CI/cms/-/pipelines/16904
-
core-ci voted on patch set 4 V -1 09/18/21, 13:14 Core CI is not happy: https://gitlab.typo3.org/typo3/CI/cms/-/pipelines/16905
-
Simon Gilli uploaded patch set 5 09/18/21, 13:36
-
core-ci voted on patch set 5 V -1 09/18/21, 13:52 Core CI is not happy: https://gitlab.typo3.org/typo3/CI/cms/-/pipelines/16906
-
Simon Gilli uploaded patch set 6 09/18/21, 14:20
-
core-ci voted on patch set 6 V +1 09/18/21, 14:36 Core CI is happy: https://gitlab.typo3.org/typo3/CI/cms/-/pipelines/16907
-
Benni Mack updated the commit message in patch set 7 09/24/21, 06:13
-
core-ci voted on patch set 7 V +1 09/24/21, 06:36 Core CI is happy: https://gitlab.typo3.org/typo3/CI/cms/-/pipelines/17132
-
Andreas Kienast voted on patch set 7 CR +1 09/24/21, 07:40
-
Markus Klein voted on patch set 7 CR +1 09/24/21, 20:16
-
Nikita Hovratov uploaded patch set 8 09/30/21, 11:39
-
Nikita Hovratov voted on patch set 8 V +1 CR +1 09/30/21, 11:52
-
core-ci voted on patch set 8 V +1 09/30/21, 11:56 Core CI is happy: https://gitlab.typo3.org/typo3/CI/cms/-/pipelines/17330
-
Nikita Hovratov rebased onto patch set 9 11/04/21, 13:50
-
Nikita Hovratov voted on patch set 9 V +1 CR +1 11/04/21, 13:50
-
Nikita Hovratov uploaded patch set 10 11/04/21, 13:53
-
Nikita Hovratov voted on patch set 10 V +1 CR +1 11/04/21, 13:54
-
core-ci voted on patch set 9 V +1 11/04/21, 14:12 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/18885
-
core-ci voted on patch set 10 V +1 11/04/21, 14:18 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/18887
-
Markus Klein commented on patch set 10 11/04/21, 14:30
SessionService.php:74this cast is totally useless, we use the expression in a boolean context, so it is cast implicitly. -
Markus Klein commented on patch set 11 11/04/21, 14:34
Published edit on patch set 10. -
Markus Klein commented on patch set 11 11/04/21, 14:34
SessionService.php:74ReplyDone -
Markus Klein voted on patch set 11 CR +1 11/04/21, 14:35
-
core-ci voted on patch set 11 V +1 11/04/21, 14:52 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/18891
-
Nikita Hovratov voted on patch set 11 V +1 CR +1 11/04/21, 15:23
-
Christian Kuhn voted on patch set 11 V +2 CR +2 11/05/21, 11:04
-
Christian Kuhn merged patch set 12 11/05/21, 11:04