Review main Merged

71125[TASK] Clean up code & add deprecation comments

Oliver Hader CR +2 V +2 Easy +4 −3 updated 09/20/21, 15:12

Commit message

* cleans up code, to avoid using "onclick" in variable name
* adds deprecation comments to simplify removing snippets in TYPO3 v12.0

Review

  • Code review CR +2 Done
    • Benjamin Franzke +2
    • Benni Mack +1
  • Verified V +2 Done
    • Benjamin Franzke +2
    • Benni Mack +1
    • core-ci +1 CI

Issues 1

Files 3

Review log 45

  1. Oliver Hader uploaded patch set 1 09/20/21, 12:41

  2. core-ci voted on patch set 1 V +1 09/20/21, 12:57 Core CI is happy: https://gitlab.typo3.org/typo3/CI/cms/-/pipelines/16934

  3. Benni Mack voted on patch set 1 V +1 CR +1 09/20/21, 15:03

  4. Benjamin Franzke voted on patch set 1 V +2 CR +2 09/20/21, 15:12

  5. Benjamin Franzke merged patch set 2 09/20/21, 15:12