71132[TASK] Enforce setting up MFA
Commit message
Review
-
Code review CR +2 Done
- Oli Bartsch +2
- Oliver Hader +1
- Benni Mack +1
-
Verified V +2 Done
- Oli Bartsch +2
- Oliver Hader +1
- Benni Mack +1
- core-ci +1 CI
Issues 1
Files 17
- Build/Sources/Sass/typo3/_login_screen.scss+5 −0
- typo3/sysext/backend/Classes/Controller/AbstractMfaController.php+25 −18
- typo3/sysext/backend/Classes/Controller/MfaConfigurationController.php1+9 −17
- typo3/sysext/backend/Classes/Controller/MfaSetupController.phpnew+278 −0
- typo3/sysext/backend/Classes/Middleware/BackendUserAuthenticator.php2+31 −23
- typo3/sysext/backend/Configuration/Backend/Routes.php+6 −0
- typo3/sysext/backend/Configuration/Services.yaml+3 −0
- typo3/sysext/backend/Resources/Private/Language/locallang_mfa.xlf+36 −0
- typo3/sysext/backend/Resources/Private/Partials/Mfa/SetupInstructions.htmlnew+9 −0
- typo3/sysext/backend/Resources/Private/Templates/Mfa/Standalone/Selection.htmlnew+65 −0
- typo3/sysext/backend/Resources/Private/Templates/Mfa/Standalone/Setup.htmlnew+58 −0
- typo3/sysext/backend/Resources/Private/Templates/Mfa/Setup.html+1 −9
- typo3/sysext/backend/Resources/Public/Css/backend.css+1 −1
- typo3/sysext/backend/Tests/Functional/Controller/MfaSetupControllerTest.phpnew+355 −0
- typo3/sysext/core/Classes/Authentication/AbstractUserAuthentication.php+11 −3
- typo3/sysext/core/Classes/Authentication/BackendUserAuthentication.php+28 −0
- typo3/sysext/core/Documentation/Changelog/11.1/Feature-93526-MultiFactorAuthentication.rst+9 −4
Review log 2334
Show 59 earlier messages
-
Oli Bartsch uploaded patch set 1 09/20/21, 21:56
-
core-ci voted on patch set 1 V -1 09/20/21, 22:11 Core CI is not happy: https://gitlab.typo3.org/typo3/CI/cms/-/pipelines/16958
-
Oli Bartsch uploaded patch set 2 09/20/21, 22:29
-
core-ci voted on patch set 2 V +1 09/20/21, 22:44 Core CI is happy: https://gitlab.typo3.org/typo3/CI/cms/-/pipelines/16959
-
Oli Bartsch uploaded patch set 3 09/21/21, 16:56
-
core-ci voted on patch set 3 V +1 09/21/21, 17:23 Core CI is happy: https://gitlab.typo3.org/typo3/CI/cms/-/pipelines/17000
-
Oli Bartsch uploaded patch set 4 09/22/21, 09:09
-
core-ci voted on patch set 4 V +1 09/22/21, 09:24 Core CI is happy: https://gitlab.typo3.org/typo3/CI/cms/-/pipelines/17021
-
Oliver Hader uploaded patch set 5 09/22/21, 11:23
-
Oliver Hader commented on patch set 5 09/22/21, 11:23
Just rebased. -
core-ci voted on patch set 5 V +1 09/22/21, 11:40 Core CI is happy: https://gitlab.typo3.org/typo3/CI/cms/-/pipelines/17030
-
Oliver Hader uploaded patch set 6 09/22/21, 13:03
-
Oliver Hader voted on patch set 6 V +1 CR +1 09/22/21, 13:09
-
core-ci voted on patch set 6 V -1 09/22/21, 13:17 Core CI is not happy: https://gitlab.typo3.org/typo3/CI/cms/-/pipelines/17032
-
Oli Bartsch uploaded patch set 7 09/22/21, 14:10
-
Oliver Hader commented on patch set 7 V +1 CR +1 09/22/21, 14:19
One thing just came to my mind: When enforcing MFA, it currently is still able to disable existing MFA. Maybe it is possible to disallow that unless there are more than one handlers. Besides that, it would be great to request the token again, in case MFA and password changes are about to be performed (this could also be a separate issue/patch). -
core-ci voted on patch set 7 V +1 09/22/21, 14:37 Core CI is happy: https://gitlab.typo3.org/typo3/CI/cms/-/pipelines/17037
-
Benni Mack commented on patch set 7 09/22/21, 14:43
BackendUserAuthenticator.php:152typo. "$mfaReuquested" -
Benni Mack uploaded patch set 8 09/22/21, 14:55
-
Benni Mack voted on patch set 8 V +1 CR +1 09/22/21, 14:56
-
Oli Bartsch commented on patch set 8 09/22/21, 15:03
Reply
This is intended. Otherwise it would not be possible for a user to change e.g. the shared secret for TOTP. When deactivating a provider, while being required to have MFA, a corresponding warning is therefore shown in the module.BackendUserAuthenticator.php:152ReplyDone -
core-ci voted on patch set 8 V -1 09/22/21, 15:23 Core CI is not happy: https://gitlab.typo3.org/typo3/CI/cms/-/pipelines/17048
-
Benni Mack uploaded patch set 9 09/22/21, 15:44
-
Benni Mack voted on patch set 9 V +1 CR +1 09/22/21, 15:45
-
Oli Bartsch rebased onto patch set 10 09/22/21, 15:47
-
Benni Mack uploaded patch set 11 09/22/21, 15:58
-
Oliver Hader voted on patch set 11 V +1 CR +1 09/22/21, 16:04
-
core-ci voted on patch set 10 V +1 09/22/21, 16:05 Core CI is happy: https://gitlab.typo3.org/typo3/CI/cms/-/pipelines/17052
-
core-ci voted on patch set 9 V +1 09/22/21, 16:07 Core CI is happy: https://gitlab.typo3.org/typo3/CI/cms/-/pipelines/17051
-
Benni Mack voted on patch set 11 V +1 CR +1 09/22/21, 16:16
-
core-ci voted on patch set 11 V +1 09/22/21, 16:20 Core CI is happy: https://gitlab.typo3.org/typo3/CI/cms/-/pipelines/17055
-
Oli Bartsch voted on patch set 11 V +2 CR +2 09/22/21, 16:28
-
Oli Bartsch merged patch set 12 09/22/21, 16:28
-
Benjamin Franzke commented on patch set 12 10/05/21, 06:57
MfaConfigurationController.php:170I'd like to resolve this @todo with: https://review.typo3.org/c/Packages/TYPO3.CMS/+/71434 71434: [TASK] Resolve TODO in MFA activate action