Review main Merged

71132[TASK] Enforce setting up MFA

Oli Bartsch CR +2 V +2 Expert +930 −75 updated 10/05/21, 06:57

Commit message

With #93526, multi-factor authentication was
introduced to TYPO3. This came with several
configuration options, such as the possibility
to require MFA for specific users and user
groups. Previously, the only result of this
option was a warning, displayed in the MFA
configuration module. Obviously, this did not
really help administrators, trying  to enforce
MFA in their system.

Therefore, this patch adds the missing endpoint,
which is automatically called for all users, required
to set up MFA, as soon as they have successfully
passed the first authentication step (e.g. username
+ password).

While it's a new endpoint, the actions still call the
MFA providers the same way, the MFA configuration
module does. Therefore, no changes to the API.

Review

  • Code review CR +2 Done
    • Oli Bartsch +2
    • Oliver Hader +1
    • Benni Mack +1
  • Verified V +2 Done
    • Oli Bartsch +2
    • Oliver Hader +1
    • Benni Mack +1
    • core-ci +1 CI

Issues 1

Files 17

Review log 2334

Show 59 earlier messages
  1. Oli Bartsch uploaded patch set 1 09/20/21, 21:56

  2. core-ci voted on patch set 1 V -1 09/20/21, 22:11 Core CI is not happy: https://gitlab.typo3.org/typo3/CI/cms/-/pipelines/16958

  3. Oli Bartsch uploaded patch set 2 09/20/21, 22:29

  4. core-ci voted on patch set 2 V +1 09/20/21, 22:44 Core CI is happy: https://gitlab.typo3.org/typo3/CI/cms/-/pipelines/16959

  5. Oli Bartsch uploaded patch set 3 09/21/21, 16:56

  6. core-ci voted on patch set 3 V +1 09/21/21, 17:23 Core CI is happy: https://gitlab.typo3.org/typo3/CI/cms/-/pipelines/17000

  7. Oli Bartsch uploaded patch set 4 09/22/21, 09:09

  8. core-ci voted on patch set 4 V +1 09/22/21, 09:24 Core CI is happy: https://gitlab.typo3.org/typo3/CI/cms/-/pipelines/17021

  9. Oliver Hader uploaded patch set 5 09/22/21, 11:23

  1. Oliver Hader commented on patch set 5 09/22/21, 11:23

    Just rebased.
  2. core-ci voted on patch set 5 V +1 09/22/21, 11:40 Core CI is happy: https://gitlab.typo3.org/typo3/CI/cms/-/pipelines/17030

  3. Oliver Hader uploaded patch set 6 09/22/21, 13:03

  4. Oliver Hader voted on patch set 6 V +1 CR +1 09/22/21, 13:09

  5. core-ci voted on patch set 6 V -1 09/22/21, 13:17 Core CI is not happy: https://gitlab.typo3.org/typo3/CI/cms/-/pipelines/17032

  6. Oli Bartsch uploaded patch set 7 09/22/21, 14:10

  7. Oliver Hader commented on patch set 7 V +1 CR +1 09/22/21, 14:19

    One thing just came to my mind: When enforcing MFA, it currently is still able to disable existing MFA. Maybe it is possible to disallow that unless there are more than one handlers. Besides that, it would be great to request the token again, in case MFA and password changes are about to be performed (this could also be a separate issue/patch).
  8. core-ci voted on patch set 7 V +1 09/22/21, 14:37 Core CI is happy: https://gitlab.typo3.org/typo3/CI/cms/-/pipelines/17037

  9. Benni Mack commented on patch set 7 09/22/21, 14:43

    BackendUserAuthenticator.php:152

    typo. "$mfaReuquested"
  10. Benni Mack uploaded patch set 8 09/22/21, 14:55

  11. Benni Mack voted on patch set 8 V +1 CR +1 09/22/21, 14:56

  12. Oli Bartsch commented on patch set 8 09/22/21, 15:03

    Reply

    This is intended. Otherwise it would not be possible for a user to change e.g. the shared secret for TOTP. When deactivating a provider, while being required to have MFA, a corresponding warning is therefore shown in the module.

    BackendUserAuthenticator.php:152 Reply

    Done
  13. core-ci voted on patch set 8 V -1 09/22/21, 15:23 Core CI is not happy: https://gitlab.typo3.org/typo3/CI/cms/-/pipelines/17048

  14. Benni Mack uploaded patch set 9 09/22/21, 15:44

  15. Benni Mack voted on patch set 9 V +1 CR +1 09/22/21, 15:45

  16. Oli Bartsch rebased onto patch set 10 09/22/21, 15:47

  17. Benni Mack uploaded patch set 11 09/22/21, 15:58

  18. Oliver Hader voted on patch set 11 V +1 CR +1 09/22/21, 16:04

  19. core-ci voted on patch set 10 V +1 09/22/21, 16:05 Core CI is happy: https://gitlab.typo3.org/typo3/CI/cms/-/pipelines/17052

  20. core-ci voted on patch set 9 V +1 09/22/21, 16:07 Core CI is happy: https://gitlab.typo3.org/typo3/CI/cms/-/pipelines/17051

  21. Benni Mack voted on patch set 11 V +1 CR +1 09/22/21, 16:16

  22. core-ci voted on patch set 11 V +1 09/22/21, 16:20 Core CI is happy: https://gitlab.typo3.org/typo3/CI/cms/-/pipelines/17055

  23. Oli Bartsch voted on patch set 11 V +2 CR +2 09/22/21, 16:28

  24. Oli Bartsch merged patch set 12 09/22/21, 16:28

  25. Benjamin Franzke commented on patch set 12 10/05/21, 06:57

    MfaConfigurationController.php:170

    I'd like to resolve this @todo with: https://review.typo3.org/c/Packages/TYPO3.CMS/+/71434 71434: [TASK] Resolve TODO in MFA activate action