Review main Merged

71133[BUGFIX] Keep extbase attributes in OriginalRequest

Torben Hansen CR +2 V +2 Normal +62 −1 updated 10/01/21, 08:33

Commit message

When an Extbase action returns a ForwardResponse, the
extbase attributes of the originalRequest are overwritten,
because the resulting request object is cloned from the
current request which holds a reference to extbase
attributes.

This change ensures, that the extbase attributes
remain in their original state in the originalRequest
object.

Review

  • Code review CR +2 Done
    • Benjamin Franzke +2
    • Nikita Hovratov +1
  • Verified V +2 Done
    • Benjamin Franzke +2
    • Nikita Hovratov +1
    • core-ci +1 CI

Issues 1

Files 2

Review log 1220

  1. Torben Hansen uploaded patch set 1 09/21/21, 06:11

  2. core-ci voted on patch set 1 V -1 09/21/21, 08:15 Core CI is not happy: https://gitlab.typo3.org/typo3/CI/cms/-/pipelines/16963

  3. Torben Hansen updated the commit message in patch set 2 09/21/21, 16:45

  4. core-ci voted on patch set 2 V -1 09/21/21, 18:48 Core CI is not happy: https://gitlab.typo3.org/typo3/CI/cms/-/pipelines/16998

  5. Torben Hansen uploaded patch set 3 09/22/21, 17:44

  6. core-ci voted on patch set 3 V +1 09/22/21, 18:02 Core CI is happy: https://gitlab.typo3.org/typo3/CI/cms/-/pipelines/17067

  7. Torben Hansen uploaded patch set 4 09/22/21, 18:18

  8. core-ci voted on patch set 4 V +1 09/22/21, 18:49 Core CI is happy: https://gitlab.typo3.org/typo3/CI/cms/-/pipelines/17072

  9. Torben Hansen updated the commit message in patch set 5 09/23/21, 06:19

  10. core-ci voted on patch set 5 V +1 09/23/21, 06:36 Core CI is happy: https://gitlab.typo3.org/typo3/CI/cms/-/pipelines/17093

  11. Torben Hansen uploaded patch set 6 09/25/21, 17:43

  12. core-ci voted on patch set 6 V +1 09/25/21, 17:59 Core CI is happy: https://gitlab.typo3.org/typo3/CI/cms/-/pipelines/17192

  13. Torben Hansen updated the commit message in patch set 7 09/27/21, 06:27

  14. core-ci voted on patch set 7 V +1 09/27/21, 06:45 Core CI is happy: https://gitlab.typo3.org/typo3/CI/cms/-/pipelines/17206

  15. Benni Mack voted on patch set 7 CR +1 09/27/21, 11:12

  16. Benjamin Franzke uploaded patch set 8 10/01/21, 07:52

  17. core-ci voted on patch set 8 V +1 10/01/21, 08:12 Core CI is happy: https://gitlab.typo3.org/typo3/CI/cms/-/pipelines/17385

  18. Nikita Hovratov voted on patch set 8 V +1 CR +1 10/01/21, 08:31

  19. Benjamin Franzke voted on patch set 8 V +2 CR +2 10/01/21, 08:33

  20. Benjamin Franzke merged patch set 9 10/01/21, 08:33