Review main Merged

71135[TASK] Consistently use str_starts_with and str_ends_with

Benni Mack CR +2 V +2 Hard +302 −224 updated 09/21/21, 15:50

Commit message

With PHP 8.0 and symfony/polyfill-php80 it is possible to use
native str_starts_with() and str_ends_with() methods.

This way, the methods

* StringUtility::beginsWith()
* StringUtility::endsWith()

are marked as deprecated.

Review

  • Code review CR +2 Done
    • Benni Mack +2
    • Oli Bartsch +1
    • Wouter Wolters +1
  • Verified V +2 Done
    • Benni Mack +2
    • Oli Bartsch +1
    • Wouter Wolters +1
    • core-ci +1 CI

Issues 1

Files 23

Show 3 more files

Review log 68

  1. Benni Mack uploaded patch set 1 09/21/21, 06:53

  2. core-ci voted on patch set 1 V +1 09/21/21, 07:12 Core CI is happy: https://gitlab.typo3.org/typo3/CI/cms/-/pipelines/16966

  3. Benni Mack uploaded patch set 2 09/21/21, 09:29

  4. core-ci voted on patch set 2 V +1 09/21/21, 09:44 Core CI is happy: https://gitlab.typo3.org/typo3/CI/cms/-/pipelines/16979

  5. Oli Bartsch voted on patch set 2 V +1 CR +1 09/21/21, 12:30

  6. Wouter Wolters voted on patch set 2 V +1 CR +1 09/21/21, 14:51

  7. Benni Mack voted on patch set 2 V +2 CR +2 09/21/21, 15:50

  8. Benni Mack merged patch set 3 09/21/21, 15:50