Review main Merged

71162[DOCS] enableMassActions is a User TSconfig option

Francois Suter CR +2 V +2 Easy +15 −15 updated 09/21/21, 11:26

Commit message

The setting options.workspaces.enableMassActions is described in the
extension manual as being a Page TSconfig option, whereas it is a
User TSconfig option.

Review

  • Code review CR +2 Done
    • Benni Mack +2
    • Oli Bartsch +1
    • Stephan Großberndt +1
    • Xavier Perseguers +1
  • Verified V +2 Done
    • Benni Mack +2
    • Oli Bartsch +1
    • Xavier Perseguers +1
    • core-ci +1 CI

Issues 1

Files 1

Review log 1011

  1. Francois Suter uploaded patch set 1 09/21/21, 10:48

  2. Xavier Perseguers voted on patch set 1 V +1 CR +1 09/21/21, 10:54

  3. Xavier Perseguers commented on patch set 1 09/21/21, 10:55

    Index.rst:93

    Did you check whether this label is used in one of the "core" documents? I guess no
  4. core-ci voted on patch set 1 V +1 09/21/21, 11:03 Core CI is happy: https://gitlab.typo3.org/typo3/CI/cms/-/pipelines/16980

  5. Francois Suter commented on patch set 1 09/21/21, 11:05

    I thought about keeping it and thought it wasn't worth it. Now I have checked and it's indeed never used, at least in TCA, TYPO3 Explained, TypoScript Reference and TSconfig Reference. Do you consider that this is good enough?

    Index.rst:93 Reply

    I thought about keeping it and thought it wasn't worth it. Now I have checked and it's indeed never used, at least in TCA, TYPO3 Explained, TypoScript Reference and TSconfig Reference. Do you consider that this is good enough?
  6. Oli Bartsch voted on patch set 1 V +1 CR +1 09/21/21, 11:08

  7. Stephan Großberndt voted on patch set 1 CR +1 09/21/21, 11:08

  8. Xavier Perseguers commented on patch set 1 09/21/21, 11:14

    Index.rst:93 Reply

    Yes, that's enough. There's no need to keep it for keeping it. I was among the few ones actually using cross-linking with external manuals so we're safe it must not be used but thanks for double-checking with other official manuals though.
  9. Xavier Perseguers commented on patch set 1 09/21/21, 11:15

    Index.rst:93 Reply

    Ack
  10. Benni Mack voted on patch set 1 V +2 CR +2 09/21/21, 11:26

  11. Benni Mack merged patch set 2 09/21/21, 11:26