71164[TASK] Fluid Viewhelpers will be declared final in v12
Commit message
Review
-
Code review CR +2 Done
- Christian Kuhn +2
- Oli Bartsch +1
- Mathias Brodala +1
- Helmut Hummel +1
-
Verified V +2 Done
- Christian Kuhn +2
- Oli Bartsch +1
- Helmut Hummel +1
- core-ci +1 CI
Issues 1
Files 1
Review log 1113
-
Christian Kuhn uploaded patch set 1 09/21/21, 11:52
-
Helmut Hummel voted on patch set 1 V +1 CR +1 09/21/21, 12:04
-
core-ci voted on patch set 1 V +1 09/21/21, 12:05 Core CI is happy: https://gitlab.typo3.org/typo3/CI/cms/-/pipelines/16983
-
Oli Bartsch voted on patch set 1 V +1 CR +1 09/21/21, 13:14
-
Mathias Brodala commented on patch set 1 09/21/21, 13:30
Generally +1 for finally (heh) taking this step. Only minor things about the RST.Important-95298-FluidViewHelpersWillBeDeclaredFinalInV12.rst:4IMO this should be "viewhelpers" or "Viewhelpers" everywhere to make it easier to read.Important-95298-FluidViewHelpersWillBeDeclaredFinalInV12.rst:26FluidImportant-95298-FluidViewHelpersWillBeDeclaredFinalInV12.rst:30Here the :php: role and the code highlighting in general should be dropped. This is no code. -
Christian Kuhn commented on patch set 1 09/21/21, 14:24
Important-95298-FluidViewHelpersWillBeDeclaredFinalInV12.rst:4ReplyDoneImportant-95298-FluidViewHelpersWillBeDeclaredFinalInV12.rst:26ReplyDoneImportant-95298-FluidViewHelpersWillBeDeclaredFinalInV12.rst:30ReplyDone -
Christian Kuhn uploaded patch set 2 09/21/21, 14:26
-
Oli Bartsch voted on patch set 2 V +1 CR +1 09/21/21, 14:28
-
core-ci voted on patch set 2 V +1 09/21/21, 14:42 Core CI is happy: https://gitlab.typo3.org/typo3/CI/cms/-/pipelines/16992
-
Mathias Brodala voted on patch set 2 CR +1 09/21/21, 15:45
-
Helmut Hummel voted on patch set 2 V +1 CR +1 09/21/21, 15:49
-
Christian Kuhn voted on patch set 2 V +2 CR +2 09/21/21, 15:50
-
Christian Kuhn merged patch set 3 09/21/21, 15:50