Review main Merged

71164[TASK] Fluid Viewhelpers will be declared final in v12

Christian Kuhn CR +2 V +2 Easy +36 −0 updated 09/21/21, 15:50

Commit message

Communication patch for an upcoming v12 change.

We've had the situation a couple of times that core
changed Fluid Viewhelpers to adapt them to current
needs, keeping the template arguments, but changing
internal handling and method signatures.

It happened that developers then stepped up with
"This broke my own Viewhelper!" and we had to act
upon. The ImageViewHelper for instance has been a
victim of this.

From a framework point of view, Viewhelpers are
specific implementations tailored for specific use.
In most cases, they're small codewise. Extending
these classes and changing their scope should not
be supported. Developers should extend a matching
abstract instead of extending specific VH's.

The patch brings an Important.rst to pitch an
upcoming v12 change that will declare all Viewhelpers
final. The core currently of course also extends
a couple of VH's itself, but this is too
late for v11 now to change and adapt. Instead,
we'll take the time in v12 to resolve these cases
and will have a look at the abstract classes as
well to see which VH functionality should be
included in abstracts to simplify re-use and
transition for extension authors and to sharpen
core API.

Review

  • Code review CR +2 Done
    • Christian Kuhn +2
    • Oli Bartsch +1
    • Mathias Brodala +1
    • Helmut Hummel +1
  • Verified V +2 Done
    • Christian Kuhn +2
    • Oli Bartsch +1
    • Helmut Hummel +1
    • core-ci +1 CI

Issues 1

Files 1

Review log 1113

  1. Christian Kuhn uploaded patch set 1 09/21/21, 11:52

  2. Helmut Hummel voted on patch set 1 V +1 CR +1 09/21/21, 12:04

  3. core-ci voted on patch set 1 V +1 09/21/21, 12:05 Core CI is happy: https://gitlab.typo3.org/typo3/CI/cms/-/pipelines/16983

  4. Oli Bartsch voted on patch set 1 V +1 CR +1 09/21/21, 13:14

  5. Mathias Brodala commented on patch set 1 09/21/21, 13:30

    Generally +1 for finally (heh) taking this step. Only minor things about the RST.

    Important-95298-FluidViewHelpersWillBeDeclaredFinalInV12.rst:4

    IMO this should be "viewhelpers" or "Viewhelpers" everywhere to make it easier to read.

    Important-95298-FluidViewHelpersWillBeDeclaredFinalInV12.rst:26

    Fluid

    Important-95298-FluidViewHelpersWillBeDeclaredFinalInV12.rst:30

    Here the :php: role and the code highlighting in general should be dropped. This is no code.
  6. Christian Kuhn commented on patch set 1 09/21/21, 14:24

    Important-95298-FluidViewHelpersWillBeDeclaredFinalInV12.rst:4 Reply

    Done

    Important-95298-FluidViewHelpersWillBeDeclaredFinalInV12.rst:26 Reply

    Done

    Important-95298-FluidViewHelpersWillBeDeclaredFinalInV12.rst:30 Reply

    Done
  7. Christian Kuhn uploaded patch set 2 09/21/21, 14:26

  8. Oli Bartsch voted on patch set 2 V +1 CR +1 09/21/21, 14:28

  9. core-ci voted on patch set 2 V +1 09/21/21, 14:42 Core CI is happy: https://gitlab.typo3.org/typo3/CI/cms/-/pipelines/16992

  10. Mathias Brodala voted on patch set 2 CR +1 09/21/21, 15:45

  11. Helmut Hummel voted on patch set 2 V +1 CR +1 09/21/21, 15:49

  12. Christian Kuhn voted on patch set 2 V +2 CR +2 09/21/21, 15:50

  13. Christian Kuhn merged patch set 3 09/21/21, 15:50