Review main Merged

71165[BUGFIX] Hide mass action selector when empty

Francois Suter CR +2 V +2 Easy +15 −13 updated 09/21/21, 14:58

Commit message

In the workspaces module, hide the mass action selector when no actions
are available. In particular, this is the case when
options.workspaces.enableMassActions = 0 has been set in User TSconfig.

Review

  • Code review CR +2 Done
    • Benni Mack +2
    • Oli Bartsch +1
    • Wouter Wolters +1
  • Verified V +2 Done
    • Benni Mack +2
    • Oli Bartsch +1
    • Wouter Wolters +1
    • core-ci +1 CI

Issues 1

Files 1

Review log 912

  1. Francois Suter uploaded patch set 1 09/21/21, 11:58

  2. Francois Suter rebased onto patch set 2 09/21/21, 11:59

  3. Wouter Wolters voted on patch set 2 CR +1 09/21/21, 12:05

  4. core-ci voted on patch set 1 V +1 09/21/21, 12:11 Core CI is happy: https://gitlab.typo3.org/typo3/CI/cms/-/pipelines/16984

  5. core-ci voted on patch set 2 V +1 09/21/21, 12:20 Core CI is happy: https://gitlab.typo3.org/typo3/CI/cms/-/pipelines/16985

  6. Oli Bartsch uploaded patch set 3 09/21/21, 13:10

  7. Oli Bartsch commented on patch set 3 V +1 CR +1 09/21/21, 13:12

    Thanks for your patch. I just simplified the if clause a bit.
  8. core-ci voted on patch set 3 V +1 09/21/21, 13:24 Core CI is happy: https://gitlab.typo3.org/typo3/CI/cms/-/pipelines/16989

  9. Francois Suter commented on patch set 3 09/21/21, 13:54

    OK, fine. About <f:then> I thought it was a form of best practice to use it even if there's no else clause, but no worries.
  10. Wouter Wolters voted on patch set 3 V +1 CR +1 09/21/21, 14:49

  11. Benni Mack voted on patch set 3 V +2 CR +2 09/21/21, 14:58

  12. Benni Mack merged patch set 4 09/21/21, 14:58