Review main Merged

71166[BUGFIX] Properly add columns for uploaded files

Oli Bartsch CR +2 V +2 Easy +24 −11 updated 09/22/21, 15:52

Commit message

A couple of patches changed the amount of columns,
shown in the filelist module listing. For example, since
column selector component. Also multi record selection,
introduced in #94906, adds an additional column,
providing the checkbox.

This patch therefore adjusts the DragUploader component
to take this into account while dynamically adding rows for
uploaded files.

Review

  • Code review CR +2 Done
    • Oliver Hader +2
    • Benni Mack +1
  • Verified V +2 Done
    • Oliver Hader +2
    • Benni Mack +1
    • core-ci +1 CI

Issues 3

Files 5

Review log 1014

  1. Oli Bartsch uploaded patch set 1 09/21/21, 12:07

  2. core-ci voted on patch set 1 V +1 09/21/21, 12:25 Core CI is happy: https://gitlab.typo3.org/typo3/CI/cms/-/pipelines/16986

  3. Oli Bartsch uploaded patch set 2 09/21/21, 16:51

  4. core-ci voted on patch set 2 V +1 09/21/21, 17:07 Core CI is happy: https://gitlab.typo3.org/typo3/CI/cms/-/pipelines/16999

  5. Oli Bartsch uploaded patch set 3 09/22/21, 09:17

  6. core-ci voted on patch set 3 V +1 09/22/21, 09:38 Core CI is happy: https://gitlab.typo3.org/typo3/CI/cms/-/pipelines/17022

  7. Benni Mack voted on patch set 3 V +1 CR +1 09/22/21, 10:54

  8. Oli Bartsch uploaded patch set 4 09/22/21, 11:54

  9. Benni Mack voted on patch set 4 V +1 CR +1 09/22/21, 11:57

  10. core-ci voted on patch set 4 V +1 09/22/21, 12:09 Core CI is happy: https://gitlab.typo3.org/typo3/CI/cms/-/pipelines/17031

  11. Oliver Hader commented on patch set 4 CR +1 09/22/21, 15:48

    I will test this soon
  12. Oliver Hader commented on patch set 4 09/22/21, 15:52

    This looks good to me!
  13. Oliver Hader voted on patch set 4 V +2 CR +2 09/22/21, 15:52

  14. Oliver Hader merged patch set 5 09/22/21, 15:52