Review main Merged

71169[TASK] Fix undefined array key error in ActionMenuItemViewHelper

Wouter Wolters CR +2 V +2 Easy +1 −1 updated 09/21/21, 20:41

Commit message

The variable $this->arguments['selected'] is not always set.

Review

  • Code review CR +2 Done
    • Oli Bartsch +2
    • Christian Kuhn +1
  • Verified V +2 Done
    • Oli Bartsch +2
    • Christian Kuhn +1
    • core-ci +1 CI

Issues 1

Files 1

Review log 45

  1. Wouter Wolters uploaded patch set 1 09/21/21, 17:46

  2. core-ci voted on patch set 1 V +1 09/21/21, 18:03 Core CI is happy: https://gitlab.typo3.org/typo3/CI/cms/-/pipelines/17004

  3. Christian Kuhn voted on patch set 1 V +1 CR +1 09/21/21, 20:33

  4. Oli Bartsch voted on patch set 1 V +2 CR +2 09/21/21, 20:41

  5. Oli Bartsch merged patch set 2 09/21/21, 20:41