Review main Abandoned

71171[WIP][TASK] Code improvements for Tests

Wouter Wolters CR 0 V 0 Hard +262 −282 updated 10/04/21, 15:24

Commit message

Various improvements given by PHPstorm code inspections.

Is this something we can use?

Review

  • Code review CR 0
  • Verified V 0

Files 53

Show 33 more files

Review log 46

  1. Wouter Wolters uploaded patch set 1 09/21/21, 18:09

  2. core-ci voted on patch set 1 V -1 09/21/21, 18:13 Core CI is not happy: https://gitlab.typo3.org/typo3/CI/cms/-/pipelines/17006

  3. Wouter Wolters uploaded patch set 2 09/22/21, 06:58

  4. core-ci voted on patch set 2 V -1 09/22/21, 07:22 Core CI is not happy: https://gitlab.typo3.org/typo3/CI/cms/-/pipelines/17016

  5. Benni Mack commented on patch set 2 09/22/21, 07:29

    That looks weird, at least by doing this automatically, some things "LogLevelAlias" do not make sense at all
  6. Wouter Wolters abandoned the change 10/04/21, 15:24