Review main Merged

71174[TASK] Avoid undefined variables/array access in admin panel

Susi Moog CR +2 V +2 Easy +14 −9 updated 09/22/21, 07:49

Commit message

Fixes both admin panel and time tracker
array access warnings with PHP8.

Review

  • Code review CR +2 Done
    • Georg Ringer +2
    • Wouter Wolters +1
    • Andreas Kienast +1
  • Verified V +2 Done
    • Georg Ringer +2
    • Andreas Kienast +1
    • core-ci +1 CI

Issues 1

Files 3

Review log 68

  1. Susi Moog uploaded patch set 1 09/22/21, 06:39

  2. Susi Moog uploaded patch set 2 09/22/21, 06:49

  3. core-ci voted on patch set 1 V -1 09/22/21, 07:01 Core CI is not happy: https://gitlab.typo3.org/typo3/CI/cms/-/pipelines/17014

  4. core-ci voted on patch set 2 V +1 09/22/21, 07:04 Core CI is happy: https://gitlab.typo3.org/typo3/CI/cms/-/pipelines/17015

  5. Wouter Wolters voted on patch set 2 CR +1 09/22/21, 07:14

  6. Andreas Kienast commented on patch set 2 V +1 CR +1 09/22/21, 07:17

    Verified by watching screen share.
  7. Georg Ringer voted on patch set 2 V +2 CR +2 09/22/21, 07:48

  8. Georg Ringer merged patch set 3 09/22/21, 07:49