71176[TASK] Deprecate parseFunc.sword functionality
Commit message
Review
-
Code review CR +2 Done
- Georg Ringer +2
- Wouter Wolters +1
- Oliver Hader +1
-
Verified V +2 Done
- Georg Ringer +2
- Oliver Hader +1
- core-ci +1 CI
Issues 1
Files 4
- typo3/sysext/core/Documentation/Changelog/master/Deprecation-95318-TypoScriptParseFuncsword.rstnew+62 −0
- typo3/sysext/fluid_styled_content/Configuration/TypoScript/Helper/ParseFunc.typoscript+1 −0
- typo3/sysext/frontend/Classes/ContentObject/ContentObjectRenderer.php+8 −2
- typo3/sysext/indexed_search/Classes/Controller/SearchController.php+1 −0
Review log 1215
-
Benni Mack uploaded patch set 1 09/22/21, 13:50
-
core-ci voted on patch set 1 V +1 09/22/21, 14:20 Core CI is happy: https://gitlab.typo3.org/typo3/CI/cms/-/pipelines/17034
-
Oliver Hader commented on patch set 1 CR +1 09/22/21, 16:28
In general: +1 -
Benni Mack updated the commit message in patch set 2 09/22/21, 16:42
-
core-ci voted on patch set 2 V +1 09/22/21, 16:59 Core CI is happy: https://gitlab.typo3.org/typo3/CI/cms/-/pipelines/17061
-
Benni Mack uploaded patch set 3 09/22/21, 17:01
-
Oliver Hader voted on patch set 3 CR +1 09/22/21, 17:11
-
core-ci voted on patch set 3 V +1 09/22/21, 17:14 Core CI is happy: https://gitlab.typo3.org/typo3/CI/cms/-/pipelines/17063
-
Wouter Wolters voted on patch set 3 CR +1 09/22/21, 17:16
-
Oliver Hader voted on patch set 3 V +1 09/22/21, 17:29
-
Georg Ringer voted on patch set 3 V +2 CR +2 09/22/21, 17:29
-
Georg Ringer merged patch set 4 09/22/21, 17:29
-
Oliver Hader commented on patch set 4 09/22/21, 17:33
Maybe it's worth mentioning something like https://wicg.github.io/scroll-to-text-fragment/ Example im Chrome: https://en.wikipedia.org/wiki/Cat#:~:text=On%20islands,%20birds%20can%20contribute%20as%20much%20as%2060%25%20of%20a%20cat's%20diet -
Oliver Hader commented on patch set 4 09/22/21, 17:43
Reply
On client-side support can be detected with e.g. `typeof FragmentDirective === 'function'` -
Oliver Hader commented on patch set 4 09/22/21, 17:45
Reply
Oh, did not know there's a polyfill: https://github.com/GoogleChromeLabs/text-fragments-polyfill