Review main Merged

71176[TASK] Deprecate parseFunc.sword functionality

Benni Mack CR +2 V +2 Normal +72 −2 updated 09/22/21, 17:45

Commit message

The parseFunc.sword functionality wraps HTML (usually a span tag)
around RTE-based content if:
* GET parameter ?sword[]=search-word is set
* no_cache=1 is set via GET parameter or TypoScript

This feature only works in non-cached environments due to the actual
problem that the search term should never be cached.

This happens if a result page in indexed search is clicked, which
then receives a no_cache=1 argument. This feature is highly discouraged
due to the possible server load that is created, and thus removed.

The existing solution is far from optimal and should rather be handled in
third-party extensions (such as EXT:solr does it via a HighlightViewHelper).

Review

  • Code review CR +2 Done
    • Georg Ringer +2
    • Wouter Wolters +1
    • Oliver Hader +1
  • Verified V +2 Done
    • Georg Ringer +2
    • Oliver Hader +1
    • core-ci +1 CI

Issues 1

Files 4

Review log 1215

  1. Benni Mack uploaded patch set 1 09/22/21, 13:50

  2. core-ci voted on patch set 1 V +1 09/22/21, 14:20 Core CI is happy: https://gitlab.typo3.org/typo3/CI/cms/-/pipelines/17034

  3. Oliver Hader commented on patch set 1 CR +1 09/22/21, 16:28

    In general: +1
  4. Benni Mack updated the commit message in patch set 2 09/22/21, 16:42

  5. core-ci voted on patch set 2 V +1 09/22/21, 16:59 Core CI is happy: https://gitlab.typo3.org/typo3/CI/cms/-/pipelines/17061

  6. Benni Mack uploaded patch set 3 09/22/21, 17:01

  7. Oliver Hader voted on patch set 3 CR +1 09/22/21, 17:11

  8. core-ci voted on patch set 3 V +1 09/22/21, 17:14 Core CI is happy: https://gitlab.typo3.org/typo3/CI/cms/-/pipelines/17063

  9. Wouter Wolters voted on patch set 3 CR +1 09/22/21, 17:16

  10. Oliver Hader voted on patch set 3 V +1 09/22/21, 17:29

  11. Georg Ringer voted on patch set 3 V +2 CR +2 09/22/21, 17:29

  12. Georg Ringer merged patch set 4 09/22/21, 17:29

  13. Oliver Hader commented on patch set 4 09/22/21, 17:43

    Reply

    On client-side support can be detected with e.g. `typeof FragmentDirective === 'function'`
  14. Oliver Hader commented on patch set 4 09/22/21, 17:45

    Reply