Review main Merged

71177[TASK] Deprecate GeneralUtility::isAbsPath()

Benni Mack CR +2 V +2 Normal +57 −20 updated 09/27/21, 11:37

Commit message

The replacement "PathUtility::isAbsolutePath()" works the same
way and has been around for a long time. For this reason
"GeneralUtility::isAbsPath()" is deprecated.

Review

  • Code review CR +2 Done
    • Benni Mack +2
    • Oli Bartsch +1
    • Wouter Wolters +1
  • Verified V +2 Done
    • Benni Mack +2
    • Oli Bartsch +1
    • Wouter Wolters +1
    • core-ci +1 CI

Issues 1

Files 8

Review log 813

  1. Benni Mack uploaded patch set 1 09/22/21, 14:01

  2. core-ci voted on patch set 1 V -1 09/22/21, 14:38 Core CI is not happy: https://gitlab.typo3.org/typo3/CI/cms/-/pipelines/17035

  3. Benni Mack uploaded patch set 2 09/27/21, 09:10

  4. core-ci voted on patch set 2 V +1 09/27/21, 09:25 Core CI is happy: https://gitlab.typo3.org/typo3/CI/cms/-/pipelines/17217

  5. Oliver Klee updated the commit message in patch set 3 09/27/21, 09:30

  6. core-ci voted on patch set 3 V +1 09/27/21, 09:47 Core CI is happy: https://gitlab.typo3.org/typo3/CI/cms/-/pipelines/17218

  7. Benni Mack uploaded patch set 4 09/27/21, 10:33

  8. core-ci voted on patch set 4 V -1 09/27/21, 10:52 Core CI is not happy: https://gitlab.typo3.org/typo3/CI/cms/-/pipelines/17224

  9. core-ci voted on patch set 4 V +1 09/27/21, 11:04 Core CI is happy: https://gitlab.typo3.org/typo3/CI/cms/-/pipelines/17224

  10. Wouter Wolters voted on patch set 4 V +1 CR +1 09/27/21, 11:18

  11. Oli Bartsch voted on patch set 4 V +1 CR +1 09/27/21, 11:37

  12. Benni Mack voted on patch set 4 V +2 CR +2 09/27/21, 11:37

  13. Benni Mack merged patch set 5 09/27/21, 11:37