71178[TASK] Do not use custom "getInstance()" methods on Singleton interfaces
Commit message
Review
-
Code review CR +2 Done
- Benni Mack +2
- Oli Bartsch +1
- Wouter Wolters +1
-
Verified V +2 Done
- Benni Mack +2
- Oli Bartsch +1
- Wouter Wolters +1
- core-ci +1 CI
Issues 1
Files 40
- typo3/sysext/backend/Classes/Controller/OnlineMediaController.php+1 −1
- typo3/sysext/backend/Classes/Form/Container/InlineControlContainer.php+1 −1
- typo3/sysext/core/Classes/Resource/Index/ExtractorRegistry.php+2 −0
- typo3/sysext/core/Classes/Resource/Index/FileIndexRepository.php+2 −0
- typo3/sysext/core/Classes/Resource/Index/Indexer.php+2 −2
- typo3/sysext/core/Classes/Resource/Index/MetaDataRepository.php+2 −0
- typo3/sysext/core/Classes/Resource/OnlineMedia/Helpers/AbstractOnlineMediaHelper.php+1 −1
- typo3/sysext/core/Classes/Resource/OnlineMedia/Helpers/OnlineMediaHelperRegistry.php+2 −0
- typo3/sysext/core/Classes/Resource/OnlineMedia/Metadata/Extractor.php+3 −4
- typo3/sysext/core/Classes/Resource/OnlineMedia/Processing/PreviewProcessing.php+2 −2
- typo3/sysext/core/Classes/Resource/Rendering/RendererRegistry.php+2 −0
- typo3/sysext/core/Classes/Resource/Rendering/VimeoRenderer.php+2 −1
- typo3/sysext/core/Classes/Resource/Rendering/YouTubeRenderer.php+1 −1
- typo3/sysext/core/Classes/Resource/Service/ExtractorService.php+2 −1
- typo3/sysext/core/Classes/Resource/TextExtraction/TextExtractorRegistry.php+2 −0
- typo3/sysext/core/Classes/Resource/ResourceFactory.php+1 −1
- typo3/sysext/core/Classes/Resource/ResourceStorage.php+2 −2
- typo3/sysext/core/Documentation/Changelog/master/Deprecation-95326-VariousGetInstanceStaticMethodsOnSingletonInterfaces.rstnew+49 −0
- typo3/sysext/core/Tests/Unit/Resource/Rendering/RendererRegistryTest.php+1 −1
- typo3/sysext/core/ext_localconf.php+3 −3
Show 20 more files
- typo3/sysext/filelist/Classes/Controller/File/CreateFolderController.php+1 −1
- typo3/sysext/fluid/Classes/ViewHelpers/MediaViewHelper.php+1 −1
- typo3/sysext/form/Classes/Controller/FormEditorController.php+3 −3
- typo3/sysext/form/Classes/Controller/FormManagerController.php+2 −2
- typo3/sysext/form/Classes/Domain/Configuration/ConfigurationService.php+1 −1
- typo3/sysext/form/Classes/Domain/Finishers/AbstractFinisher.php+2 −1
- typo3/sysext/form/Classes/Domain/Finishers/EmailFinisher.php+1 −1
- typo3/sysext/form/Classes/Hooks/DataStructureIdentifierHook.php+1 −1
- typo3/sysext/form/Classes/Hooks/FormElementHooks.php+1 −1
- typo3/sysext/form/Classes/Mvc/Property/TypeConverter/UploadedFileReferenceConverter.php+8 −8
- typo3/sysext/form/Classes/Service/TranslationService.php+2 −0
- typo3/sysext/form/Classes/ViewHelpers/TranslateElementErrorViewHelper.php+2 −1
- typo3/sysext/form/Classes/ViewHelpers/TranslateElementPropertyViewHelper.php+2 −1
- typo3/sysext/install/Configuration/ExtensionScanner/Php/MethodCallStaticMatcher.php+63 −0
- typo3/sysext/recordlist/Classes/View/FolderUtilityRenderer.php+1 −1
- typo3/sysext/scheduler/Classes/Task/FileStorageExtractionAdditionalFieldProvider.php+1 −1
- typo3/sysext/t3editor/Classes/Form/Element/T3editorElement.php+8 −5
- typo3/sysext/t3editor/Classes/Registry/AddonRegistry.php+2 −0
- typo3/sysext/t3editor/Classes/Registry/ModeRegistry.php+2 −0
- typo3/sysext/t3editor/Classes/T3editor.php+1 −1
Review log 710
-
Benni Mack uploaded patch set 1 09/22/21, 14:08
-
core-ci voted on patch set 1 V +1 09/22/21, 14:32 Core CI is happy: https://gitlab.typo3.org/typo3/CI/cms/-/pipelines/17036
-
Benni Mack uploaded patch set 2 09/23/21, 07:24
-
Benni Mack uploaded patch set 3 09/23/21, 07:31
-
core-ci voted on patch set 2 V +1 09/23/21, 07:37 Core CI is happy: https://gitlab.typo3.org/typo3/CI/cms/-/pipelines/17094
-
core-ci voted on patch set 3 V +1 09/23/21, 07:45 Core CI is happy: https://gitlab.typo3.org/typo3/CI/cms/-/pipelines/17095
-
Wouter Wolters voted on patch set 3 V +1 CR +1 09/23/21, 08:08
-
Oli Bartsch voted on patch set 3 V +1 CR +1 09/23/21, 10:43
-
Benni Mack voted on patch set 3 V +2 CR +2 09/23/21, 10:59
-
Benni Mack merged patch set 4 09/23/21, 10:59