Review main Merged

71179[TASK] Mark various internal TSFE methods as protected

Benni Mack CR +2 V +2 Easy +5 −6 updated 09/22/21, 17:43

Commit message

Various methods within TypoScripFrontendController
are now "protected" as they are marked as internal.

Review

  • Code review CR +2 Done
    • Georg Ringer +2
    • Wouter Wolters +1
  • Verified V +2 Done
    • Georg Ringer +2
    • Wouter Wolters +1
    • core-ci +1 CI

Issues 1

Files 1

Review log 811

  1. Benni Mack uploaded patch set 1 09/22/21, 14:10

  2. core-ci voted on patch set 1 V +1 09/22/21, 14:32 Core CI is happy: https://gitlab.typo3.org/typo3/CI/cms/-/pipelines/17038

  3. Benni Mack updated the commit message in patch set 2 09/22/21, 15:51

  4. Thomas Löffler commented on patch set 2 09/22/21, 16:09

    TypoScriptFrontendController.php:1909

    Why removing @internal here?
  5. core-ci voted on patch set 2 V +1 09/22/21, 16:24 Core CI is happy: https://gitlab.typo3.org/typo3/CI/cms/-/pipelines/17054

  6. Benni Mack commented on patch set 3 09/22/21, 17:02

    Published edit on patch set 2.
  7. Benni Mack commented on patch set 3 09/22/21, 17:03

    TypoScriptFrontendController.php:1909 Reply

    Thanks. Added it back.
  8. Wouter Wolters voted on patch set 3 V +1 CR +1 09/22/21, 17:17

  9. core-ci voted on patch set 3 V +1 09/22/21, 17:19 Core CI is happy: https://gitlab.typo3.org/typo3/CI/cms/-/pipelines/17064

  10. Georg Ringer voted on patch set 3 V +2 CR +2 09/22/21, 17:43

  11. Georg Ringer merged patch set 4 09/22/21, 17:43