Review TYPO3_4-5 Merged

7118[BUGFIX] TCEforms draws huge empty icon row which on select-fields

Markus Klein CR +2 V +2 Easy +1 −1 updated 06/03/13, 20:49

Commit message

Certain fields of type "select" which offer records from a
"foreign_table" will contain a huge amount of t3-icon-empty
icons just below the select box. If you have enough of them,
you even get a horizotanl scrollbar.

See some screenshots here:
http://forge.typo3.org/issues/13422

The issue is not a CSS issue, but a bug in the rendering
of such a field.

See it in action in tt_content field "sys_language". Just create
enough sys_language records so that you see the row of empty
icons being created. This wasn't this way before.

Review

  • Code review CR +2
    • Georg Ringer +2
  • Verified V +2
    • Georg Ringer +2

Issues 1

Files 1

Review log 4

  1. Oliver Hader uploaded patch set 2 12/14/11, 07:20

  2. Oliver Hader commented on patch set 2 12/14/11, 07:20

    Automated rebasing to TYPO3_4-5 - Please consider updating your reviews V:0, R:0 as a summary of previous scores (limited to [-1;+1])
  3. Georg Ringer commented on patch set 2 V 0 12/14/11, 07:20

    by team member; Looks good to me, approved
  4. Georg Ringer merged patch set 2 12/14/11, 07:20