Review main Merged

71180[TASK] Deprecate legacy Element Browser logic

Benni Mack CR +2 V +2 Normal +58 −2 updated 09/23/21, 10:58

Commit message

The hook
$GLOBALS['TYPO3_CONF_VARS']['SC_OPTIONS']['typo3/browse_links.php']['browserRendering']
is deprecated in favor of the ElementBrowser API
implemented in TYPO3 v7.6 via https://docs.typo3.org/c/typo3/cms-core/master/en-us/Changelog/7.6/Feature-66369-AddedLinkBrowserAPIs.html

Also, calling "wizard_element_browser" with mode=wizard
or "mode=rte" is deprecated, instead extensions should link to
"wizard_link", which also exists since TYPO3 v8.

Review

  • Code review CR +2 Done
    • Benni Mack +2
    • Oli Bartsch +1
    • Markus Klein +1
  • Verified V +2 Done
    • Benni Mack +2
    • Oli Bartsch +1
    • Markus Klein +1
    • core-ci +1 CI

Issues 1

Files 3

Review log 812

  1. Benni Mack uploaded patch set 1 09/22/21, 14:13

  2. core-ci voted on patch set 1 V -1 09/22/21, 14:28 Core CI is not happy: https://gitlab.typo3.org/typo3/CI/cms/-/pipelines/17039

  3. Benni Mack uploaded patch set 2 09/22/21, 19:14

  4. Benni Mack updated the commit message in patch set 3 09/22/21, 19:42

  5. core-ci voted on patch set 2 V -1 09/22/21, 19:48 Core CI is not happy: https://gitlab.typo3.org/typo3/CI/cms/-/pipelines/17077

  6. Benni Mack uploaded patch set 4 09/22/21, 19:57

  7. core-ci voted on patch set 4 V +1 09/22/21, 20:15 Core CI is happy: https://gitlab.typo3.org/typo3/CI/cms/-/pipelines/17082

  8. core-ci voted on patch set 3 V -1 09/22/21, 20:16 Core CI is not happy: https://gitlab.typo3.org/typo3/CI/cms/-/pipelines/17078

  9. Markus Klein voted on patch set 4 V +1 CR +1 09/23/21, 08:33

  10. Oli Bartsch voted on patch set 4 V +1 CR +1 09/23/21, 10:46

  11. Benni Mack voted on patch set 4 V +2 CR +2 09/23/21, 10:58

  12. Benni Mack merged patch set 5 09/23/21, 10:58