Review main Merged

71182[TASK] Deprecate various arguments within AbstractUserAuthentication/BE_USER

Benni Mack CR +2 V +2 Normal +127 −47 updated 09/24/21, 08:48

Commit message

A few methods within the *UserAuthentication have arguments deprecated.

* AbstractUserAuthentication->writeUC() - first argument deprecated
* AbstractUserAuthentication->unpack_uc() - first argument deprecated
* BackendUserAuthentication->isInWebMount() - third argument deprecated
* BackendUserAuthentication->backendCheckLogin() - first argument deprecated

Review

  • Code review CR +2 Done
    • Oli Bartsch +2
    • Wouter Wolters +1
  • Verified V +2 Done
    • Oli Bartsch +2
    • Wouter Wolters +1
    • core-ci +1 CI

Issues 1

Files 10

Review log 813

  1. Benni Mack uploaded patch set 1 09/22/21, 14:17

  2. core-ci voted on patch set 1 V +1 09/22/21, 14:53 Core CI is happy: https://gitlab.typo3.org/typo3/CI/cms/-/pipelines/17041

  3. Benni Mack uploaded patch set 2 09/22/21, 18:00

  4. Benni Mack updated the commit message in patch set 3 09/22/21, 18:11

  5. core-ci voted on patch set 2 V -1 09/22/21, 18:30 Core CI is not happy: https://gitlab.typo3.org/typo3/CI/cms/-/pipelines/17069

  6. core-ci voted on patch set 3 V -1 09/22/21, 18:39 Core CI is not happy: https://gitlab.typo3.org/typo3/CI/cms/-/pipelines/17070

  7. Benni Mack uploaded patch set 4 09/22/21, 18:39

  8. core-ci voted on patch set 4 V -1 09/22/21, 19:28 Core CI is not happy: https://gitlab.typo3.org/typo3/CI/cms/-/pipelines/17074

  9. Benni Mack rebased onto patch set 5 09/22/21, 19:47

  10. core-ci voted on patch set 5 V +1 09/22/21, 20:01 Core CI is happy: https://gitlab.typo3.org/typo3/CI/cms/-/pipelines/17079

  11. Wouter Wolters voted on patch set 5 V +1 CR +1 09/23/21, 17:22

  12. Oli Bartsch voted on patch set 5 V +2 CR +2 09/24/21, 08:48

  13. Oli Bartsch merged patch set 6 09/24/21, 08:48