Review main Merged

71183[DOCS] Use LocalConfiguration.php in workspaces docs

Benni Mack CR +2 V +2 Easy +1 −1 updated 09/22/21, 15:38

Commit message

ext_localconf.php still references "localconf.php" even
though it is called "LocalConfiguration.php" since
TYPO3 v6.0.

Review

  • Code review CR +2 Done
    • Christian Kuhn +2
    • Oliver Hader +1
  • Verified V +2 Done
    • Christian Kuhn +2
    • Oliver Hader +1
    • core-ci +1 CI

Issues 1

Files 1

Review log 810

  1. Benni Mack uploaded patch set 1 09/22/21, 14:22

  2. Benni Mack updated the commit message in patch set 2 09/22/21, 14:34

  3. core-ci voted on patch set 1 V +1 09/22/21, 14:44 Core CI is happy: https://gitlab.typo3.org/typo3/CI/cms/-/pipelines/17042

  4. core-ci voted on patch set 2 V +1 09/22/21, 15:06 Core CI is happy: https://gitlab.typo3.org/typo3/CI/cms/-/pipelines/17045

  5. Oliver Hader commented on patch set 2 09/22/21, 15:18

    I am going to review this now...
  6. Oliver Hader commented on patch set 2 CR +1 09/22/21, 15:19

    This looks good, I will test this soon
  7. Oliver Hader commented on patch set 2 V +1 09/22/21, 15:19

    I just realized, that nothing was to be tested here
  8. Christian Kuhn voted on patch set 2 V +1 CR +1 09/22/21, 15:34

  9. Christian Kuhn voted on patch set 2 V +2 CR +2 09/22/21, 15:38

  10. Christian Kuhn merged patch set 3 09/22/21, 15:38