Review main Merged

71184[TASK] Deprecate old syntax for IRRE localize synchronize in DataHandler

Benni Mack CR +2 V +2 Easy +47 −0 updated 09/22/21, 17:44

Commit message

With TYPO3 v7.6 the internal DataHandler command to
"inlineLocalizeSynchronize" was migrated to an array-based
syntax, and TYPO3 Core uses this ever since.

With TYPO3 v11 it is time to deprecate the old behavior.

Review

  • Code review CR +2 Done
    • Georg Ringer +2
    • Wouter Wolters +1
    • Oliver Hader +1
  • Verified V +2 Done
    • Georg Ringer +2
    • Wouter Wolters +1
    • Oliver Hader +1
    • core-ci +1 CI

Issues 1

Files 2

Review log 1114

  1. Benni Mack uploaded patch set 1 09/22/21, 14:24

  2. core-ci voted on patch set 1 V -1 09/22/21, 14:29 Core CI is not happy: https://gitlab.typo3.org/typo3/CI/cms/-/pipelines/17043

  3. Oliver Hader commented on patch set 1 09/22/21, 16:28

    In general: +1
  4. Benni Mack updated the commit message in patch set 2 09/22/21, 16:34

  5. Jo Hasenau voted on patch set 2 CR +1 09/22/21, 16:36

  6. core-ci voted on patch set 2 V -1 09/22/21, 16:40 Core CI is not happy: https://gitlab.typo3.org/typo3/CI/cms/-/pipelines/17059

  7. Benni Mack uploaded patch set 3 09/22/21, 16:41

  8. core-ci voted on patch set 3 V +1 09/22/21, 16:55 Core CI is happy: https://gitlab.typo3.org/typo3/CI/cms/-/pipelines/17060

  9. Oliver Hader commented on patch set 3 09/22/21, 17:11

    Good catch, I should have marked that with "@deprecated" back then in 7.6 times...
  10. Oliver Hader voted on patch set 3 V +1 CR +1 09/22/21, 17:11

  11. Benni Mack commented on patch set 3 09/22/21, 17:13

    @Jo care to vote again?
  12. Wouter Wolters voted on patch set 3 V +1 CR +1 09/22/21, 17:17

  13. Georg Ringer voted on patch set 3 V +2 CR +2 09/22/21, 17:44

  14. Georg Ringer merged patch set 4 09/22/21, 17:44