Review main Merged

71186[TASK] Optional internal_type="db" for type="group"

Christian Kuhn CR +2 V +2 Normal +86 −155 updated 09/30/21, 07:05

Commit message

Most common use case for TCA type "group" fields is
the usage of "internal_type=db". Therefore, this
option is now the default value. This allows to
simplify corresponding parts in FormEngine,
Datahandler, etc. Furthermore are all Core TCA
files adjusted and do no longer define this
option for type "group".

Review

  • Code review CR +2 Done
    • Benni Mack +2
    • Nikita Hovratov +1
  • Verified V +2 Done
    • Benni Mack +2
    • Nikita Hovratov +1
    • core-ci +1 CI

Issues 1

Files 55

Show 35 more files

Review log 913

  1. Christian Kuhn uploaded patch set 1 09/22/21, 15:35

  2. core-ci voted on patch set 1 V +1 09/22/21, 15:47 Core CI is happy: https://gitlab.typo3.org/typo3/CI/cms/-/pipelines/17049

  3. Benni Mack uploaded patch set 2 09/27/21, 11:08

  4. core-ci voted on patch set 2 V +1 09/27/21, 11:26 Core CI is happy: https://gitlab.typo3.org/typo3/CI/cms/-/pipelines/17226

  5. Oli Bartsch uploaded patch set 3 09/28/21, 14:36

  6. Oli Bartsch voted on patch set 3 V +1 CR +1 09/28/21, 14:37

  7. core-ci voted on patch set 3 V +1 09/28/21, 14:56 Core CI is happy: https://gitlab.typo3.org/typo3/CI/cms/-/pipelines/17268

  8. Nikita Hovratov commented on patch set 3 09/28/21, 15:02

    TcaInlineConfiguration.php:240

    ..., but not empty and not internal_type 'db'
  9. Benni Mack commented on patch set 4 09/28/21, 19:23

    Published edit on patch set 3.
  10. core-ci voted on patch set 4 V +1 09/28/21, 19:39 Core CI is happy: https://gitlab.typo3.org/typo3/CI/cms/-/pipelines/17277

  11. Nikita Hovratov commented on patch set 4 V +1 CR +1 09/29/21, 06:50

    TcaInlineConfiguration.php:240 Reply

    Done
  12. Benni Mack voted on patch set 4 V +2 CR +2 09/30/21, 07:05

  13. Benni Mack merged patch set 5 09/30/21, 07:05