Review main Merged

71187[BUGFIX] Reintroduce DistributionWelcome image

Simon Gilli CR +2 V +2 Normal +79 −20 updated 09/22/21, 19:00

Commit message

With the change #82000 the DistributionWelcome image was removed by
accident. This patch adds the image again with a proper fallback to the
Distribution image.

Review

  • Code review CR +2 Done
    • Georg Ringer +2
    • Benni Mack +1
  • Verified V +2 Done
    • Georg Ringer +2
    • Benni Mack +1
    • core-ci +1 CI

Issues 1

Files 10

Review log 1113

  1. Simon Gilli uploaded patch set 1 09/22/21, 16:14

  2. Thomas Löffler voted on patch set 1 CR +1 09/22/21, 16:19

  3. core-ci voted on patch set 1 V +1 09/22/21, 16:37 Core CI is happy: https://gitlab.typo3.org/typo3/CI/cms/-/pipelines/17056

  4. Simon Gilli marked it ready for review 09/22/21, 16:46

  5. Benni Mack commented on patch set 1 09/22/21, 17:06

    Show.html:9

    seriously? "image2"? :D
  6. Simon Gilli uploaded patch set 2 09/22/21, 17:49

  7. Simon Gilli commented on patch set 2 09/22/21, 17:50

    Show.html:9 Reply

    Done
  8. Benni Mack commented on patch set 2 09/22/21, 18:04

    Show.html:9 Reply

    AWESOME!
  9. Simon Gilli commented on patch set 2 09/22/21, 18:15

    Show.html:9 Reply

    Yeah, you're so right. Didn't think much with that naming :D
  10. core-ci voted on patch set 2 V +1 09/22/21, 18:20 Core CI is happy: https://gitlab.typo3.org/typo3/CI/cms/-/pipelines/17068

  11. Benni Mack voted on patch set 2 V +1 CR +1 09/22/21, 18:55

  12. Georg Ringer voted on patch set 2 V +2 CR +2 09/22/21, 19:00

  13. Georg Ringer merged patch set 3 09/22/21, 19:00