Review 10.4 Merged

71194[BUGFIX] Auto redirect resolve target page

Benni Mack CR +2 V +2 Normal +46 −32 updated 09/24/21, 10:40

Commit message

When renaming pages, the pages in the automatic
redirect are now saved with the TYPO3 protocol.

Review

  • Code review CR +2 Done
    • Benni Mack +2
    • Stefan Bürk +1
  • Verified V +2 Done
    • Benni Mack +2
    • Stefan Bürk +1
    • core-ci +1 CI

Issues 1

Files 2

Review log 79

  1. Benni Mack commented on patch set 1 09/24/21, 09:08

    Cherry Picked from branch master. The following files contain Git conflicts: * typo3/sysext/redirects/Classes/Service/SlugService.php * typo3/sysext/redirects/Tests/Functional/Service/SlugServiceTest.php
  2. core-ci voted on patch set 1 V -1 09/24/21, 09:10 Core CI is not happy: https://gitlab.typo3.org/typo3/CI/cms/-/pipelines/17144

  3. Benni Mack uploaded patch set 2 09/24/21, 09:14

  4. Benni Mack marked it ready for review 09/24/21, 09:14

  5. core-ci voted on patch set 2 V +1 09/24/21, 09:27 Core CI is happy: https://gitlab.typo3.org/typo3/CI/cms/-/pipelines/17146

  6. Stefan Bürk commented on patch set 2 CR +1 09/24/21, 09:42

    Going to test/verify/check some things manually in running instance ....
  7. Stefan Bürk voted on patch set 2 V +1 09/24/21, 10:39

  8. Benni Mack voted on patch set 2 V +2 CR +2 09/24/21, 10:40

  9. Benni Mack merged patch set 3 09/24/21, 10:40