Review 10.4 Merged

71195[TASK] Add early check for validating email address

Andreas Kienast CR +2 V +2 Easy +3 −0 updated 09/24/21, 14:43

Commit message

GeneralUtility::validEmail is called for all legacy link formats like
page ids. To avoid triggering Egulias\EmailValidator an early check for
the `@` sign has been added.

Review

  • Code review CR +2 Done
    • Andreas Kienast +2
  • Verified V +2 Done
    • Andreas Kienast +2
    • core-ci +1 CI

Issues 1

Files 1

Review log 69

  1. Andreas Kienast commented on patch set 1 09/24/21, 13:28

    Cherry Picked from branch master. The following files contain Git conflicts: * typo3/sysext/core/Classes/Utility/GeneralUtility.php
  2. Andreas Kienast uploaded patch set 2 09/24/21, 13:29

  3. core-ci voted on patch set 1 V -1 09/24/21, 13:31 Core CI is not happy: https://gitlab.typo3.org/typo3/CI/cms/-/pipelines/17157

  4. Andreas Kienast uploaded patch set 3 09/24/21, 13:31

  5. core-ci voted on patch set 2 V -1 09/24/21, 13:31 Core CI is not happy: https://gitlab.typo3.org/typo3/CI/cms/-/pipelines/17158

  6. Andreas Kienast marked it ready for review 09/24/21, 13:32

  7. core-ci voted on patch set 3 V +1 09/24/21, 13:42 Core CI is happy: https://gitlab.typo3.org/typo3/CI/cms/-/pipelines/17160

  8. Andreas Kienast voted on patch set 3 V +2 CR +2 09/24/21, 14:43

  9. Andreas Kienast merged patch set 4 09/24/21, 14:43