Review main Merged

71213[BUGFIX] Do not show disabled checkbox

Oli Bartsch CR +2 V +2 Easy +5 −2 updated 09/23/21, 08:43

Commit message

Revert a style change, added in #95325, which
led to disabled checkboxes are being shown, while
only their label should be visible. Those checkbox
classes hide the actual checkbox, while the label
acts as one. This allows extended styling, e.g.
"icon checkboxes" or "toggle checkboxes".

Instead add the disabled style to the correct
checkbox component, which is acutally using the
checkbox element and no label.

Review

  • Code review CR +2 Done
    • Benni Mack +2
    • Wouter Wolters +1
  • Verified V +2 Done
    • Benni Mack +2
    • Wouter Wolters +1
    • core-ci +1 CI

Issues 1

Files 3

Review log 812

  1. Oli Bartsch uploaded patch set 1 09/22/21, 21:52

  2. Oli Bartsch updated the commit message in patch set 2 09/22/21, 21:53

  3. Oli Bartsch uploaded patch set 3 09/22/21, 22:04

  4. core-ci voted on patch set 1 V -1 09/22/21, 22:07 Core CI is not happy: https://gitlab.typo3.org/typo3/CI/cms/-/pipelines/17085

  5. core-ci voted on patch set 2 V -1 09/22/21, 22:15 Core CI is not happy: https://gitlab.typo3.org/typo3/CI/cms/-/pipelines/17086

  6. core-ci voted on patch set 3 V -1 09/22/21, 22:24 Core CI is not happy: https://gitlab.typo3.org/typo3/CI/cms/-/pipelines/17087

  7. Oli Bartsch rebased onto patch set 4 09/22/21, 22:38

  8. core-ci voted on patch set 4 V +1 09/22/21, 23:01 Core CI is happy: https://gitlab.typo3.org/typo3/CI/cms/-/pipelines/17088

  9. Benni Mack voted on patch set 4 V +1 CR +1 09/23/21, 07:10

  10. Wouter Wolters voted on patch set 4 V +1 CR +1 09/23/21, 08:14

  11. Benni Mack voted on patch set 4 V +2 CR +2 09/23/21, 08:43

  12. Benni Mack merged patch set 5 09/23/21, 08:43