71214[BUGFIX] Push PackageManager to ExtensionManagementUtility in Bootstrap
Commit message
Review
-
Code review CR +2 Done
- Oli Bartsch +2
- Benjamin Franzke +1
- Benni Mack +1
-
Verified V +2 Done
- Oli Bartsch +2
- Benjamin Franzke +1
- Benni Mack +1
- core-ci +1 CI
Issues 2
Files 1
Review log 1014
-
Oli Bartsch uploaded patch set 1 09/23/21, 09:21
-
Oli Bartsch updated the commit message in patch set 2 09/23/21, 09:22
-
Benjamin Franzke commented on patch set 2 CR -1 09/23/21, 09:24
Thanks, I think we need to do this for v10 (although I never intended to support PackageManager/ExtensionManagementUtility usage in Services.php), as it used to work. But we'd then even need to make PackageManager instance available via GU:makeInstance. Will take care, therefore -1 for now. -
core-ci voted on patch set 1 V +1 09/23/21, 09:38 Core CI is happy: https://gitlab.typo3.org/typo3/CI/cms/-/pipelines/17097
-
core-ci voted on patch set 2 V +1 09/23/21, 09:39 Core CI is happy: https://gitlab.typo3.org/typo3/CI/cms/-/pipelines/17098
-
Benjamin Franzke uploaded patch set 3 09/23/21, 19:11
-
Benjamin Franzke commented on patch set 3 09/23/21, 19:11
Reply
> as it used to work. I meant: "although it worked implicitly". -
core-ci voted on patch set 3 V -1 09/23/21, 19:15 Core CI is not happy: https://gitlab.typo3.org/typo3/CI/cms/-/pipelines/17121
-
Benjamin Franzke uploaded patch set 4 09/23/21, 19:42
-
core-ci voted on patch set 4 V +1 09/23/21, 19:57 Core CI is happy: https://gitlab.typo3.org/typo3/CI/cms/-/pipelines/17123
-
Oli Bartsch voted on patch set 4 V +1 CR +1 09/23/21, 20:34
-
Benni Mack voted on patch set 4 V +1 CR +1 09/24/21, 08:18
-
Oli Bartsch voted on patch set 4 V +2 CR +2 09/24/21, 08:36
-
Oli Bartsch merged patch set 5 09/24/21, 08:36