Review main Merged

71219[TASK] Remove legacy handling of new content element wizard

Benni Mack CR +2 V +2 Hard +244 −110 updated 09/23/21, 15:56

Commit message

Before TYPO3 v7 introduced modals, TYPO3's New Content Element Wizard
could be opened within the list frame as a full document.

The corresponding controller code has now been removed, along
with some legacy functionality and inline JavaScript related
to PagePositionMaps, which are used within the
NewContentElementController, along with some
legacy GeneralUtility::_GP() calls.

In addition, the ContentCreationPagePositionMap
does not inherit from PagePositionMap anymore, as it only
had a minor overlap of functionality.

Review

  • Code review CR +2 Done
    • Oliver Hader +2
    • Oli Bartsch +1
  • Verified V +2 Done
    • Oliver Hader +2
    • Oli Bartsch +1
    • core-ci +1 CI

Issues 1

Files 5

Review log 913

  1. Benni Mack uploaded patch set 1 09/23/21, 13:56

  2. Oliver Hader voted on patch set 1 CR +1 09/23/21, 14:06

  3. Oliver Hader voted on patch set 1 V +1 09/23/21, 14:09

  4. core-ci voted on patch set 1 V +1 09/23/21, 14:09 Core CI is happy: https://gitlab.typo3.org/typo3/CI/cms/-/pipelines/17106

  5. Benni Mack uploaded patch set 2 09/23/21, 14:30

  6. Benni Mack uploaded patch set 3 09/23/21, 14:32

  7. core-ci voted on patch set 2 V -1 09/23/21, 14:48 Core CI is not happy: https://gitlab.typo3.org/typo3/CI/cms/-/pipelines/17107

  8. core-ci voted on patch set 3 V -1 09/23/21, 14:52 Core CI is not happy: https://gitlab.typo3.org/typo3/CI/cms/-/pipelines/17108

  9. Benni Mack uploaded patch set 4 09/23/21, 14:57

  10. core-ci voted on patch set 4 V +1 09/23/21, 15:17 Core CI is happy: https://gitlab.typo3.org/typo3/CI/cms/-/pipelines/17112

  11. Oli Bartsch voted on patch set 4 V +1 CR +1 09/23/21, 15:19

  12. Oliver Hader voted on patch set 4 V +2 CR +2 09/23/21, 15:56

  13. Oliver Hader merged patch set 5 09/23/21, 15:56