Review main Merged

71223[TASK] Add required attribute to input fields of filelist module

Georg Ringer CR +2 V +2 Easy +2 −2 updated 10/13/21, 10:57

Commit message

The forms to add a new media asset and to create a new textfile require
a value. Using the attribute `required` improves the usability.

Review

  • Code review CR +2 Done
    • Oli Bartsch +2
    • Josef Glatz +1
    • Björn Jacob +1
    • Wouter Wolters +1
  • Verified V +2 Done
    • Oli Bartsch +2
    • Josef Glatz +1
    • Björn Jacob +1
    • Wouter Wolters +1
    • core-ci +1 CI

Issues 1

Files 1

Review log 910

  1. Georg Ringer uploaded patch set 1 09/23/21, 18:14

  2. Georg Ringer commented on patch set 1 09/23/21, 18:14

    This change is ready for review.
  3. core-ci voted on patch set 1 V +1 09/23/21, 18:32 Core CI is happy: https://gitlab.typo3.org/typo3/CI/cms/-/pipelines/17119

  4. Björn Jacob voted on patch set 1 V +1 CR +1 09/23/21, 18:40

  5. Wouter Wolters voted on patch set 1 V +1 CR +1 09/23/21, 18:48

  6. Josef Glatz voted on patch set 1 V +1 CR +1 09/23/21, 19:04

  7. Oli Bartsch commented on patch set 1 09/23/21, 20:09

    CreateFolder.html:27

    Why not adding this here, too? This currently leads to "No name for new folder given!" on submit.
  8. Georg Ringer commented on patch set 1 10/07/21, 12:27

    I don't want it there because some of those could be empty and would still be fine
  9. Oli Bartsch commented on patch set 1 V +2 CR +2 10/13/21, 10:57

    CreateFolder.html:27 Reply

    Ack
  10. Oli Bartsch merged patch set 2 10/13/21, 10:57