Review main Merged

71224[TASK] Update to node-sass 6 to support compilation with node v16

Benni Mack CR +2 V +2 Normal +32 −96 updated 09/24/21, 06:54

Commit message

Using Node 16 (will become LTS in Oct 2021)
is only possible by updating node-sass 6.

See https://github.com/sass/node-sass/issues/3077
and https://github.com/sass/node-sass/releases/tag/v6.0.0

Used command:
* yarn add "node-sass@^6.0" --dev

Review

  • Code review CR +2 Done
    • Benjamin Franzke +2
    • Andreas Kienast +1
  • Verified V +2 Done
    • Benjamin Franzke +2
    • Andreas Kienast +1
    • core-ci +1 CI

Issues 1

Files 3

Review log 811

  1. Benni Mack uploaded patch set 1 09/23/21, 19:38

  2. core-ci voted on patch set 1 V -1 09/23/21, 19:56 Core CI is not happy: https://gitlab.typo3.org/typo3/CI/cms/-/pipelines/17122

  3. Benjamin Franzke commented on patch set 1 09/23/21, 20:03

    package.json:11

    Just a thought, no blocker: We don't have a real dependency on >=16.10, right? (I mean even node-sass v6 says >= v12) That means we could also define ">=14.15.0 <17.0.0" and allow compliation both with v14 and v16. Afaict that doesn't change the build output (other than before), so why should we add a restriction that isn't actually true(?)
  4. Benjamin Franzke uploaded patch set 2 09/23/21, 20:09

  5. core-ci voted on patch set 2 V +1 09/23/21, 20:24 Core CI is happy: https://gitlab.typo3.org/typo3/CI/cms/-/pipelines/17124

  6. Benni Mack commented on patch set 2 09/24/21, 06:08

    package.json:11 Reply

    yes. agreed
  7. Benni Mack updated the commit message in patch set 3 09/24/21, 06:08

  8. core-ci voted on patch set 3 V +1 09/24/21, 06:29 Core CI is happy: https://gitlab.typo3.org/typo3/CI/cms/-/pipelines/17131

  9. Andreas Kienast voted on patch set 3 V +1 CR +1 09/24/21, 06:43

  10. Benjamin Franzke voted on patch set 3 V +2 CR +2 09/24/21, 06:53

  11. Benjamin Franzke merged patch set 4 09/24/21, 06:54