Review main Merged

71225[TASK] Remove unused code from NewContentElementController

Oli Bartsch CR +2 V +2 Normal +89 −125 updated 09/24/21, 06:22

Commit message

In #95331 the legacy usage of the wizard as a full document
has been removed. This patch removes some further leftovers.

- Unused definition of docheader buttons is removed
- Protected property $moduleTemplate is removed due to single usage
- Protected property $menuItemView is removed due to single usage
- Guard clause is added to prepareContent()

Review

  • Code review CR +2 Done
    • Benni Mack +2
    • Anja Leichsenring +1
  • Verified V +2 Done
    • Benni Mack +2
    • Anja Leichsenring +1
    • core-ci +1 CI

Issues 2

Files 1

Review log 56

  1. Oli Bartsch uploaded patch set 1 09/23/21, 22:29

  2. core-ci voted on patch set 1 V +1 09/23/21, 22:50 Core CI is happy: https://gitlab.typo3.org/typo3/CI/cms/-/pipelines/17127

  3. Benni Mack voted on patch set 1 V +1 CR +1 09/24/21, 06:11

  4. Anja Leichsenring voted on patch set 1 V +1 CR +1 09/24/21, 06:22

  5. Benni Mack voted on patch set 1 V +2 CR +2 09/24/21, 06:22

  6. Benni Mack merged patch set 2 09/24/21, 06:22