Review main Merged

71227[TASK] Move code for PagePositionMap

Benni Mack CR +2 V +2 Hard +232 −269 updated 09/24/21, 08:43

Commit message

This change moves code from PagePositionMap into
the subclass ContentMovingPagePositionMap. This code is only
used (showing colPos) when a content is placed / moved, and thus does not
need to reside in the main class.

Review

  • Code review CR +2 Done
    • Oli Bartsch +2
    • Andreas Kienast +1
  • Verified V +2 Done
    • Oli Bartsch +2
    • Andreas Kienast +1
    • core-ci +1 CI

Issues 1

Files 3

Review log 45

  1. Benni Mack uploaded patch set 1 09/24/21, 07:19

  2. core-ci voted on patch set 1 V +1 09/24/21, 07:33 Core CI is happy: https://gitlab.typo3.org/typo3/CI/cms/-/pipelines/17134

  3. Andreas Kienast voted on patch set 1 V +1 CR +1 09/24/21, 07:39

  4. Oli Bartsch voted on patch set 1 V +2 CR +2 09/24/21, 08:43

  5. Oli Bartsch merged patch set 2 09/24/21, 08:43