Review main Merged

71229[TASK] Get rid of deprecated TBE_EDITOR.fieldChanged invocation

Oliver Hader CR +2 V +2 Easy +13 −2 updated 09/28/21, 08:33

Commit message

Substitutes deprecated invocation of `TBE_EDITOR.fieldChanged`.
Relevant processing has been duplicated from `TBE_EDITOR` to
corresponding `FormEngine` event handler. Throwing a new `change`
event from a `change` event handler is counterproductive and would
lead to an endless loop.

Review

  • Code review CR +2 Done
    • Oliver Hader +2
    • Oli Bartsch +1
    • Stefan Bürk +1
  • Verified V +2 Done
    • Oliver Hader +2
    • Oli Bartsch +1
    • Stefan Bürk +1
    • core-ci +1 CI

Issues 1

Files 2

Review log 1014

  1. Oliver Hader uploaded patch set 1 09/24/21, 12:59

  2. Andreas Kienast uploaded patch set 2 09/24/21, 13:24

  3. core-ci voted on patch set 1 V -1 09/24/21, 13:29 Core CI is not happy: https://gitlab.typo3.org/typo3/CI/cms/-/pipelines/17151

  4. core-ci voted on patch set 2 V -1 09/24/21, 13:49 Core CI is not happy: https://gitlab.typo3.org/typo3/CI/cms/-/pipelines/17156

  5. Oliver Hader uploaded patch set 3 09/24/21, 15:33

  6. core-ci voted on patch set 3 V -1 09/24/21, 16:01 Core CI is not happy: https://gitlab.typo3.org/typo3/CI/cms/-/pipelines/17167

  7. Oliver Hader uploaded patch set 4 09/24/21, 16:43

  8. core-ci voted on patch set 4 V +1 09/24/21, 17:03 Core CI is happy: https://gitlab.typo3.org/typo3/CI/cms/-/pipelines/17170

  9. Oli Bartsch voted on patch set 4 CR +1 09/25/21, 11:28

  10. Stefan Bürk voted on patch set 4 CR +1 09/27/21, 08:13

  11. Oli Bartsch voted on patch set 4 V +1 09/27/21, 21:13

  12. Stefan Bürk voted on patch set 4 V +1 09/28/21, 08:32

  13. Oliver Hader voted on patch set 4 V +2 CR +2 09/28/21, 08:32

  14. Oliver Hader merged patch set 5 09/28/21, 08:33