Review main Merged

71231[TASK] Deprecate page.includeCSS/includeCSSLibs.my-identifier.import

Benni Mack CR +2 V +2 Normal +62 −0 updated 09/24/21, 14:25

Commit message

The option to use the `@import` syntax for including
external CSS files through TypoScript has been deprecated.

This was possible through:

page = PAGE
page.includeCSSLibs.file1 = fileadmin/benni.css
page.includeCSSLibs.file1.import = 1

Through the "import = 1" option the output was

<style>
 @import url('fileadmin/benni.css');
</style>

instead of using the <link> tag.

Using the link tag, which is the de-facto syntax these days,
allows to load a file directly when interpreting the HTML of the
browser, instead of first interpreting the HTML, then the CSS
and have a blocking call to an external URL to continue interpreting
the CSS.

Review

  • Code review CR +2 Done
    • Oli Bartsch +2
    • Andreas Kienast +1
  • Verified V +2 Done
    • Oli Bartsch +2
    • Andreas Kienast +1
    • core-ci +1 CI

Issues 1

Files 2

Review log 710

  1. Benni Mack uploaded patch set 1 09/24/21, 13:11

  2. Benni Mack updated the commit message in patch set 2 09/24/21, 13:11

  3. core-ci voted on patch set 1 V +1 09/24/21, 13:30 Core CI is happy: https://gitlab.typo3.org/typo3/CI/cms/-/pipelines/17154

  4. Oli Bartsch voted on patch set 2 V +1 CR +1 09/24/21, 13:45

  5. core-ci voted on patch set 2 V +1 09/24/21, 13:50 Core CI is happy: https://gitlab.typo3.org/typo3/CI/cms/-/pipelines/17155

  6. Andreas Kienast uploaded patch set 3 09/24/21, 14:07

  7. Andreas Kienast voted on patch set 3 V +1 CR +1 09/24/21, 14:07

  8. core-ci voted on patch set 3 V +1 09/24/21, 14:19 Core CI is happy: https://gitlab.typo3.org/typo3/CI/cms/-/pipelines/17162

  9. Oli Bartsch commented on patch set 3 V +2 CR +2 09/24/21, 14:25

    Waiting
  10. Oli Bartsch merged patch set 4 09/24/21, 14:25