Review main Merged

71233[TASK] Deprecate custom JSWindow options in HMENU settings

Benni Mack CR +2 V +2 Normal +52 −0 updated 09/24/21, 14:41

Commit message

The HMENU / TMENU options for opening up links of a menu
in a custom JavaScript popup are deprecated. Respective settings:

page.123 = HMENU
page.123.1 = TMENU
page.123.1.JSWindow = 1
page.123.1.JSWindow.params = width=200,height=300,status=0,menubar=0

alternatively this syntax was possible as well:

page.123.1 = TMENU
page.123.1.target = 200x300

both variants and properties related to JavaScript are now
deprecated.

Review

  • Code review CR +2 Done
    • Oli Bartsch +2
    • Oliver Hader +1
  • Verified V +2 Done
    • Oli Bartsch +2
    • Oliver Hader +1
    • core-ci +1 CI

Issues 1

Files 2

Review log 68

  1. Benni Mack uploaded patch set 1 09/24/21, 13:42

  2. core-ci voted on patch set 1 V +1 09/24/21, 13:59 Core CI is happy: https://gitlab.typo3.org/typo3/CI/cms/-/pipelines/17161

  3. Benni Mack uploaded patch set 2 09/24/21, 14:19

  4. Oliver Hader voted on patch set 2 CR +1 09/24/21, 14:28

  5. Oliver Hader voted on patch set 2 V +1 09/24/21, 14:31

  6. core-ci voted on patch set 2 V +1 09/24/21, 14:37 Core CI is happy: https://gitlab.typo3.org/typo3/CI/cms/-/pipelines/17164

  7. Oli Bartsch voted on patch set 2 V +2 CR +2 09/24/21, 14:40

  8. Oli Bartsch merged patch set 3 09/24/21, 14:41